Add expandable plugin sidebar sub-items - #2768
Open
MacHatter1 wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Plugin navigation panels could register only one flat sidebar destination, so a plugin with several related views had to consume multiple top-level rows or build navigation inside its panel. The app and SDK had no contract for child destinations, active-route selection, or expandable sidebar presentation.
What changed
experimental_sidebarSubItemsplugin navigation contract, including child paths, icons, and sidebar accessories while preserving existing top-levelexperimental_sidebarAccessorybehavior.HOST_DAEMON_PROTOCOL_VERSIONis unchanged.How you verified
pnpm exec turbo run typecheck --force --concurrency=4 --filter=@bb/app --filter=@bb/server --filter=@get-bb/plugin-sdk --filter=@bb/plugin-api-map --filter=bb-plugin-plugin-api-testerpnpm exec turbo run build --force --concurrency=4 --filter=@bb/app --filter=@bb/server --filter=@get-bb/plugin-sdk --filter=@bb/plugin-api-map --filter=bb-plugin-plugin-api-testerPluginNavSidebarItems, plugin nav-panel chrome, the Plugin SDK app harness, plugin authoring docs, the API map, andbb-plugin-plugin-api-tester.Fixes: N/A