Recognize machine-detail settings URLs as app routes - #2746
Open
Danielalnajjar wants to merge 1 commit into
Open
Recognize machine-detail settings URLs as app routes#2746Danielalnajjar wants to merge 1 commit into
Danielalnajjar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
SETTINGS_MACHINE_ROUTE_PATHwas mounted by React Router but omitted from the sharedROUTE_PATTERNSinventory.isRoutePaththerefore rejected valid/settings/machines/:hostIdURLs, which maderesolveRouteHrefreturnnullfor same-origin machine-detail links and caused desktop open-tab handling to ignore a route the app supports.What changed
Added
SETTINGS_MACHINE_ROUTE_PATHtobaseRoutePatternsand added focused coverage that machine-detail paths are accepted by bothisRoutePathandresolveRouteHref.This is a client-only route-classification correction. It changes no server/daemon wire contract, CLI, SDK, persistence, documentation, or
HOST_DAEMON_PROTOCOL_VERSION.How you verified
/settings/machines/host_123covering both route classification and same-origin href resolution.mainatf4bbc2fe81a9b7639ff9a7396e172bddd89109e4and contains one production-line addition plus the focused regression. Current-head CI and the independent current-head validation are intentionally pending while the PR remains a draft.Fixes
No linked GitHub issue; fixes the missing machine-detail route classification.