Skip to content

Recognize machine-detail settings URLs as app routes - #2746

Open
Danielalnajjar wants to merge 1 commit into
get-bb:mainfrom
Danielalnajjar:fix/machine-detail-route-pattern
Open

Recognize machine-detail settings URLs as app routes#2746
Danielalnajjar wants to merge 1 commit into
get-bb:mainfrom
Danielalnajjar:fix/machine-detail-route-pattern

Conversation

@Danielalnajjar

Copy link
Copy Markdown
Contributor

Human comments

What was wrong

SETTINGS_MACHINE_ROUTE_PATH was mounted by React Router but omitted from the shared ROUTE_PATTERNS inventory. isRoutePath therefore rejected valid /settings/machines/:hostId URLs, which made resolveRouteHref return null for same-origin machine-detail links and caused desktop open-tab handling to ignore a route the app supports.

What changed

Added SETTINGS_MACHINE_ROUTE_PATH to baseRoutePatterns and added focused coverage that machine-detail paths are accepted by both isRoutePath and resolveRouteHref.

This is a client-only route-classification correction. It changes no server/daemon wire contract, CLI, SDK, persistence, documentation, or HOST_DAEMON_PROTOCOL_VERSION.

How you verified

  • Added a focused regression for /settings/machines/host_123 covering both route classification and same-origin href resolution.
  • In isolated fail-before/pass-after validation, the route test reported 1 failed / 13 passed before the production change and 14 / 14 passed afterward.
  • The branch is based directly on current main at f4bbc2fe81a9b7639ff9a7396e172bddd89109e4 and contains one production-line addition plus the focused regression. Current-head CI and the independent current-head validation are intentionally pending while the PR remains a draft.

Fixes

No linked GitHub issue; fixes the missing machine-detail route classification.

AGENT GENERATED
GPT 5.6 Pro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant