Skip to content

PB-2395: follow up cosmetic fixes - #minor - #183

Merged
adk-swisstopo merged 4 commits into
masterfrom
PB-2395-retry2
Sep 9, 2026
Merged

PB-2395: follow up cosmetic fixes - #minor#183
adk-swisstopo merged 4 commits into
masterfrom
PB-2395-retry2

Conversation

@adk-swisstopo

@adk-swisstopo adk-swisstopo commented Sep 9, 2026

Copy link
Copy Markdown
Member

I merged #182 before @asteiner-swisstopo completed his review. This addresses most of the points he raised there.

It does not address the comment about removing or updating the wording of "third party libraries" section. I sort of like it as is. But you are welcome to send your own PR if you think it's important.

Test link

@github-actions github-actions Bot changed the title PB-2395: follow up cosmetic fixes PB-2395: follow up cosmetic fixes - #minor Sep 9, 2026
@adk-swisstopo adk-swisstopo added the bug Something isn't working as expected label Sep 9, 2026
@adk-swisstopo
adk-swisstopo marked this pull request as ready for review September 9, 2026 15:11

@asteiner-swisstopo asteiner-swisstopo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Seems the blank lines between the items of the numbered list did not have any effect, that's just how VuePress looks like 🤷

I still don't like the "Third party libraries" section but I can live with it 😏

@adk-swisstopo
adk-swisstopo merged commit 7d73e7b into master Sep 9, 2026
19 of 21 checks passed
@adk-swisstopo
adk-swisstopo deleted the PB-2395-retry2 branch September 9, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants