Fix: reserve bottom inset so system IME bar doesn't cover bottom row - #148
Open
miroyong wants to merge 1 commit into
Open
Fix: reserve bottom inset so system IME bar doesn't cover bottom row#148miroyong wants to merge 1 commit into
miroyong wants to merge 1 commit into
Conversation
The keyboard fills its full window height, so the bottom row of keys sits flush against the bottom of the screen, underneath the system IME bar (arrow-to-hide + language globe). Reserve the system's bottom window inset in KeyboardLayoutView so the bottom row stays visible above that bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The keyboard fills its full window height, so the bottom row of keys sits flush against the bottom of the screen — right underneath the system IME bar (the one with the arrow to hide the keyboard and the language globe). On devices/nav modes where that bar overlays the bottom of the IME, the bottom row of keys gets covered.
Fix
In
KeyboardLayoutView, read the system's bottom window inset (nav/IME bar height) viaonApplyWindowInsets(with a fallback inonAttachedToWindowviagetRootWindowInsets), and reserve that space inonLayoutso the bottom row stays visible above the bar.bottomInsetstays0and behavior is unchanged.Verification
Compiled a debug APK successfully (aapt2 arm64). Manual testing on device recommended to confirm the bottom row is no longer covered.