Portability cleanups: no compiler warning if there is no dlopen; no GAP warning if UNIXSelect is missing - #6540
Open
fingolfin wants to merge 2 commits into
Open
Portability cleanups: no compiler warning if there is no dlopen; no GAP warning if UNIXSelect is missing#6540fingolfin wants to merge 2 commits into
fingolfin wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The method can only ever run for pty based iostreams, which require subprocess support; without it (native Windows) its reference to UNIXSelect produced a syntax warning at every startup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fingolfin
added
the
os: windows
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6540 +/- ##
==========================================
- Coverage 79.00% 78.98% -0.03%
==========================================
Files 684 684
Lines 294205 294209 +4
Branches 8647 8681 +34
==========================================
- Hits 232444 232374 -70
- Misses 59955 60027 +72
- Partials 1806 1808 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fingolfin
added
topic: kernel
topic: library
release notes: not needed
lgoettgens
approved these changes
Aug 31, 2026
Comment on lines
1462
to
+1468
| ############################################################################# | ||
| ## | ||
| #M ReadAllLine( <iostream>[, <nofail>][, <IsAllLine>] ) . . read whole line | ||
| ## | ||
| # this method serves pty based iostreams, which only exist on systems that | ||
| # also have UNIXSelect | ||
| if IsBound( UNIXSelect ) then |
Member
There was a problem hiding this comment.
Suggested change
| if IsBound( UNIXSelect ) then | |
| # this method serves pty based iostreams, which only exist on systems that | |
| # also have UNIXSelect | |
| if IsBound( UNIXSelect ) then | |
| ############################################################################# | |
| ## | |
| #M ReadAllLine( <iostream>[, <nofail>][, <IsAllLine>] ) . . read whole line | |
| ## |
I might find it more readable like this, but no strong opinion; just wanted to mention it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more portability tweaks that were created as part of the new MingW port (see issue #4157).
Co-Authored-By: Claude Fable 5 noreply@anthropic.com