Test the Julia GC integration with VALIDATE_MARKING in CI - #6526
Open
fingolfin wants to merge 1 commit into
Open
Test the Julia GC integration with VALIDATE_MARKING in CI#6526fingolfin wants to merge 1 commit into
fingolfin wants to merge 1 commit into
Conversation
fingolfin
changed the title
fingolfin
added
release notes: not needed
fingolfin
marked this pull request as ready for review
August 26, 2026 21:06
lgoettgens
approved these changes
Aug 31, 2026
Add a job to the GAP.jl workflow that builds the override GAP with VALIDATE_MARKING enabled, so regressions in the marking code abort the tests instead of going unnoticed. Requires the --validate-marking flag of etc/setup_override_dir.jl in GAP.jl master, so the job pins gapjl-version to master. This change was prepared with the assistance of Claude Code. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
fingolfin
force-pushed
the
validate-marking-ci
branch
from
August 31, 2026 13:44
49e57e0 to
a53dedf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
+ Coverage 78.98% 79.01% +0.03%
==========================================
Files 684 684
Lines 294176 294415 +239
Branches 8664 8701 +37
==========================================
+ Hits 232343 232623 +280
+ Misses 60023 59975 -48
- Partials 1810 1817 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
With oscar-system/GAP.jl#1420 merged, this should now pass CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a job to the GAP.jl workflow that builds the override GAP with
VALIDATE_MARKINGenabled, so regressions in the GC marking code abort the tests instead of going unnoticed.Stacked on #6525. Also needs the
--validate-markingflag ofetc/setup_override_dir.jlfrom oscar-system/GAP.jl#1420 in GAP.jl master, hence the job pinsgapjl-versionto master; draft until both are merged.As the last piece of the work requested there:
Fixes oscar-system/GAP.jl#1364
AI disclosure: prepared with the assistance of Claude Code.
🤖 Generated with Claude Code