fix(ubuntu): pass -username/-password to -returnlicense, restoring parity with mac/windows

[frostebite]

Carries #271 by @wschnepp, merged up to current main. Their commit and authorship are preserved — this branch exists only because the fork could not be pushed to from this session; #271 is the original and deserves the credit.

The problem (their diagnosis, unchanged)

On Ubuntu a serial-mode licence return can never succeed:

[Licensing::Module] Error: Access token is unavailable; failed to update
[Licensing::Module] Error: Failed to return entitlement license
[Licensing::Module] Error: Serial number unavailable for ULF return; skipping operation

activate.sh launches the editor with -serial/-username/-password. return_license.sh launched a fresh editor with no credentials at all, so it had no access token and could not release the entitlement. mac/steps/return_license.sh and both Windows return scripts have always passed them; the Ubuntu steps script did not.

Why this is worth noting

This was opened on 11 September. #277 independently rediscovered the identical cause on the personal path four days later, from licensing-matrix logs — same three error strings. Two code paths, one root cause, found twice. With this merged, all four platform scripts authenticate their returns on both strategies.

What changed here

Only a merge of main and an embedded-asset rebuild. The fix itself is untouched:

       -returnlicense \
+      -username "$UNITY_EMAIL" \
+      -password "$UNITY_PASSWORD" \
       -projectPath "$ACTIVATE_LICENSE_PATH"

Verification

91 tests pass. Their two assertions were confirmed load-bearing — removing the credentials fails exactly those two and nothing else:

FAIL a serial return authenticates with the account username
FAIL a serial return authenticates with the account password

Note the licensing matrix cannot catch this one: its serial cells grade unmeasurable because it runs activate and return-license in separate containers. Their unit test is the only guard, which is a good reason to have it.

Closes #271

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Added regression coverage to verify that Ubuntu license returns using serial authentication pass the configured username and password to the editor.
  • Documented expected credential handling across supported platform return workflows.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4c70272e-f468-4f15-8652-01aa22b83651

📥 Commits

Reviewing files that changed from the base of the PR and between d4cb599 and d176c90.

⛔ Files ignored due to path filters (2)

• dist/platforms/ubuntu/steps/return_license.sh is excluded by !**/dist/**
• src/generated/embedded-assets.ts is excluded by !**/generated/**

📒 Files selected for processing (1)

• scripts/test-licensing-steps.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The test suite adds Ubuntu serial-mode coverage. It verifies that return_license.sh passes the configured email and password to the editor return invocation.

Changes

Ubuntu serial return coverage

Layer / File(s)	Summary
Serial return credential regression test scripts/test-licensing-steps.sh	Adds a serial-mode test with explicit licensing credentials. The test asserts that the editor invocation includes the expected username and password.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to d176c

The change adds focused Ubuntu serial-return credential coverage, with no identified current-head risk blocking merge.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely identifies the Ubuntu credential-passing fix and its parity with macOS and Windows.
Description check	✅ Passed	The description is detailed and on-topic. It explains the problem, the code change, the rationale, and verification results. It does not reproduce the template headings or checklist, but the required …

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch contrib/271-return-license-credentials

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}