docs: fix mismatched-K "refuse to merge" claim in recently-interacted-topk - #123
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Mismatched K does not refuse to merge; a smaller-K binary silently truncates the row. Point at gallowaysoftware#101 for the wire-format fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102.
The ResolveK / README / test comments said mismatched-K sketches refuse to merge and show up as empty Top-N at query time. They don't — decode discards the wire header K and Combine merges at the constructing monoid's K, so a smaller-K writer silently truncates the row on the write path.
Updated pipeline.go, the example README, and the two test comments that repeated the same claim. Checked terraform/README.md — no matching claim there.