fix(schematron): .NET variant drives the SchXslt CLI jar — builds, runs, in CI - #29
Merged
Merged
Conversation
…ns, in CI The .NET Schematron example referenced SaxonHE12NetXslt, which NuGet publishes as a dotnet *tool*, so the project never restored (NU1212). There is no Saxon-HE library package for .NET 8 at all: Saxonica ships its .NET builds as tools only, SaxonCS is not on NuGet, and the third-party IKVM cross-compiles (SaxonHE10Net31Api) fail at runtime with a missing Saxon.HE assembly. Replace the in-process Saxon pipeline with what a .NET service in a mixed shop actually does: run the self-contained SchXslt CLI jar (bundles its own Saxon) as a child process (java from $JAVA_HOME or PATH; jar from $FUNDSXML_SCHXSLT_JAR or the Maven local repo, as before) and own the result - SVRL parsing, error/warning classification by @ROLE (failed-assert and successful-report alike) and the 0/1/2 exit-code contract shared with the Java example and svrl-summary.py. No NuGet dependencies remain. Verified (.NET SDK 8, JDK 26): canonical sample 0 errors / 12 warnings exit 0; negative fixture 1 error exit 1; --fail-on any exit 1; missing jar and missing document exit 2 with a one-line message. CI runs the sample and the fixture through it after the Java module has populated the Maven repo. invocation/README.md row marked verified. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YXZWhwE5EbHSybt55K6oUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last open item from the review: the .NET Schematron example never restored (
SaxonHE12NetXsltis a dotnet tool,NU1212). Checked the alternatives: Saxonica ships .NET builds as tools only, SaxonCS is not on NuGet, and the third-party IKVM cross-compile (SaxonHE10Net31Api) builds but fails at runtime (missingSaxon.HEassembly).SchematronValidate.csnow runs the self-contained SchXslt CLI jar as a child process (javafrom$JAVA_HOME/PATH; jar from$FUNDSXML_SCHXSLT_JARor the Maven local repo, as before) and owns the result: SVRL parsing, classification by@role(failed-assertandsuccessful-report), same 0/1/2 exit contract as Java andsvrl-summary.py. No NuGet dependencies..csprojcleaned up;invocation/README.mdrow marked verified../mvnw compilehas populated the Maven repo with the jar.Verification (local, .NET 8 + JDK 26)
0 error(s), 12 warning(s), exit 01 error(s)(percentages 120 %), exit 1--fail-on anyon sample$FUNDSXML_SCHXSLT_JAR=/nonexistent.jarSchXslt jar not found …, exit 2SchXslt CLI failed (exit 1): …, exit 2🤖 Generated with Claude Code
https://claude.ai/code/session_01YXZWhwE5EbHSybt55K6oUZ