fix: prevent cross-process stale writes to maxRevision.json - #877
Open
WillieRuemmele wants to merge 1 commit into
Open
fix: prevent cross-process stale writes to maxRevision.json#877WillieRuemmele wants to merge 1 commit into
WillieRuemmele wants to merge 1 commit into
Conversation
Before writing the tracking file, merge in-memory state with the current on-disk state. For each member present in both, take the higher lastRetrievedFromServer value (never regress). Also take the max serverMaxRevisionCounter. This prevents a long-lived process (e.g. VS Code Salesforce Extension) from overwriting correctly-synced values with its stale in-memory cache. Fixes forcedotcom/cli#3612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxRevision.json, merge in-memory state with the current on-disk statelastRetrievedFromServer(never regress)serverMaxRevisionCounterThis prevents a long-lived process (e.g. VS Code Salesforce Extension) from overwriting correctly-synced values with its stale in-memory cache. The extension holds a cached
RemoteSourceTrackingServicesingleton that was initialized on workspace open — when its background source-tracking check triggers a write, it would dump stale data back to disk, clobbering the CLI's correct writes.Fixes forcedotcom/cli#3612
Test plan
serverMaxRevisionCountertakes the maxsf project reset tracking+sf project deploy startfrom external terminal, confirmlastRetrievedFromServeris no longer nullified