Skip to content

Feat: migrate schedule settings to mui - #1071

Open
santipalenque wants to merge 2 commits into
masterfrom
feature/migrate-to-mui-schedule-settings
Open

santipalenque wants to merge 2 commits into
masterfrom
feature/migrate-to-mui-schedule-settings

Conversation

@santipalenque

@santipalenque santipalenque commented Sep 15, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/9014802374/86bbw701u

Summary by CodeRabbit

  • Improvements
    • Refreshed the Schedule Settings page with updated controls, icons, toolbar, and table experience.
    • Schedule settings now load and display using the selected sorting order.
    • Added clearer table-based actions for adding, editing, and deleting schedule settings.
    • Deletion includes a confirmation prompt and prevents removal of the default setting.
    • Improved loading feedback and handling for schedule-setting actions.
    • Improved handling of empty schedules and automatic default-setting setup.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 2a4c0f25-c466-4a9b-8c02-fd1cbf3e9c19

📥 Commits

Reviewing files that changed from the base of the PR and between 4e95f76 and 2e52b7f.

📒 Files selected for processing (1)
  • src/actions/schedule-settings-actions.js

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

ScheduleSettingsListPage was converted to a functional component and migrated to MUI table components. Loading, sorting, navigation, deletion, and default seeding were updated. New tests cover these behaviors and the empty state.

Changes

Schedule settings list

Layer / File(s) Summary
Functional table integration
src/pages/schedule_settings/schedule-settings-list-page.js
The page uses useEffect, persisted sorting, MUI controls, translated headers, and table-managed edit, delete, and seed-default actions.
Behavior coverage
src/pages/schedule_settings/__tests__/schedule-settings-list-page.test.js
Tests cover initial loading, navigation, deletion restrictions, sorting, default seeding, and the empty state.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 2e52b

The schedule-settings migration has no evidenced merge-blocking risk in the reviewed changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: migrating schedule settings to MUI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/migrate-to-mui-schedule-settings

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant