Conversation
…urn on done button Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe submission path helper now accepts an optional current selection plan ID. Preview and thank-you presentation pages pass the selected plan ID during completion. Tests verify that the current plan overrides a stored landing plan. ChangesSelection plan routing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Completion navigation now uses the currently selected plan when available, with fallback behavior retained and coverage added for stale landing-plan values. No merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
| const selectionPlanLandingId = getAllowedLandingSelectionPlanId(summit); | ||
| return selectionPlanLandingId ? `all-plans/${selectionPlanLandingId}` : 'all-plans'; | ||
| export const getSubmissionsPath = (summit, currentSelectionPlanId) => { | ||
| const selectionPlanId = currentSelectionPlanId || getAllowedLandingSelectionPlanId(summit); |
There was a problem hiding this comment.
@tomrndom @smarcet I don't think bypassing the selectionPlanId is a good idea. Please read this: https://github.com/fntechgit/call-for-presentations/blob/master/src/utils/methods.js#L268.
Maybe it should be the other way around ? if stale SP_LANDING then use presentation's selection Plan ?
ref: https://app.clickup.com/t/9014802374/86bbwpr4d
Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com
Summary by CodeRabbit
Bug Fixes
Tests