Fix skipped texts. - #1023
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors ChatSession by moving the resetting of _currentAiMessage into the shared _runRequest method to ensure all requests (including button taps) start a new message bubble. The reviewer noted that concurrent execution of _runRequest could lead to race conditions and suggested adding a guard clause to return early if a request is already processing.
There was a problem hiding this comment.
Code Review
This pull request refactors ChatSession by moving the reset of _currentAiMessage into the base _runRequest method to ensure all requests, including button-triggered ones, get their own message bubbles. The reviewer identified a potential concurrency issue where concurrent calls to _runRequest could corrupt the state or cause UI inconsistencies, and suggested guarding the method when a request is already in progress.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…sages' into fix-disappeared-messages
1 participant
Before: some text fragments recieved from model are skipped.
After: the entire message is displayed.