[tizen_window_manager] Add tizen-core-wl window backend - #1136
Closed
JSUYA wants to merge 4 commits into
Closed
Conversation
JSUYA
marked this pull request as draft
September 3, 2026 11:00
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Introduce a WindowProxyInterface abstraction with two backends selected at
runtime by WindowProxy:
- TizenCoreWlWindowProxy (tizen-core-wl) on Tizen API version >= 11.0 when
the library is available
- EcoreWl2WindowProxy (ecore_wl2) otherwise, including as a fallback when
tizen-core-wl cannot be loaded on 11.0+
Both backends implement WindowProxyInterface (GetGeometry/Activate/Lower) and
resolve their symbols at runtime via dlopen/dlsym. TizenWindowManager
constructs WindowProxy, which picks the backend by querying the platform
version at startup.
Log an error with get_error_message() when tizen_core_wl_window_get_geometry/activate/lower returns a non-zero error code, instead of silently ignoring failures.
Prevents uninitialized values from being returned to Dart when GetGeometry fails (invalid handle or backend API error).
JSUYA
force-pushed
the
tizen-core-wl-window-backend
branch
from
September 3, 2026 11:09
fa7652e to
93fb002
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a WindowProxyInterface abstraction with two backends selected at runtime by WindowProxy:
Both backends implement WindowProxyInterface (GetGeometry/Activate/Lower) and resolve their symbols at runtime via dlopen/dlsym. TizenWindowManager constructs WindowProxy, which picks the backend by querying the platform version at startup.