Skip to content

[video_player_videohole] Migrating from Platform Channels to Dart FFI #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gin7773 wants to merge 45 commits into
base: main
Choose a base branch
from
Open

[video_player_videohole] Migrating from Platform Channels to Dart FFI #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
2f0fd5d
FFI initialize and create
gin7773 Jul 16, 2026
19c4bd1
Migration of methods other than (de)activate
gin7773 Jul 17, 2026
51571e3
remove BasicMessageChannel and VideoPlayerVideoholeApi
gin7773 Jul 20, 2026
643a04d
code format
gin7773 Jul 21, 2026
1815a22
replace EventChannel with ffi
gin7773 Jul 22, 2026
93de4a2
fixed dart analyze issue
gin7773 Jul 22, 2026
3a558d6
Code refactoring
gin7773 Jul 22, 2026
46dee32
Ensure minimal changes
gin7773 Jul 22, 2026
7efc252
remove VideoPlayerTizenPlugin
gin7773 Jul 23, 2026
c6c0570
code format
gin7773 Jul 23, 2026
29d58da
fixed UI not refreshing issue and code structure updated
gin7773 Jul 28, 2026
619dc62
code format
gin7773 Jul 28, 2026
45eafa5
Complete the registration and destruction of playerEventPort, and res…
gin7773 Jul 29, 2026
f5dac1b
P1-1: Use nlohmann/json library for JSON parsing
gin7773 Jul 29, 2026
486d9e8
P1-2: Add FFI port lifecycle cleanup for hot restart
gin7773 Jul 29, 2026
16a4f83
code format
gin7773 Jul 29, 2026
b4dbc98
Fixed the potential deadlock issue and unescaped JSON issue
gin7773 Jul 30, 2026
11a01a4
Fix: FFI event port binding and Restore playback issues
gin7773 Jul 30, 2026
534df84
remove unused log
gin7773 Jul 31, 2026
4530daf
fixed some review issues
gin7773 Jul 31, 2026
2fb3939
refactor Restore()
gin7773 Jul 31, 2026
06b983b
remove unused code
gin7773 Jul 31, 2026
9996e07
fix crash issue
gin7773 Aug 5, 2026
09c5443
update version
gin7773 Aug 5, 2026
e08ba75
remove unused code
gin7773 Aug 5, 2026
daa0dd8
add ffi
gin7773 Aug 5, 2026
9866b28
Refactor: Extract FFI implementation to ffi_messages.cc
gin7773 Aug 5, 2026
6e9dd49
Simplify ffi_messages.h internal API
gin7773 Aug 5, 2026
97da2d7
Fix: Address PR review comments
gin7773 Aug 5, 2026
6582664
Fix PR #1073 review comments
gin7773 Aug 12, 2026
3cff139
Add TODO for ecore_wl2 thread safety issue
gin7773 Aug 12, 2026
0387b7c
Fixed review issues
gin7773 Aug 12, 2026
45342b6
Unified code architecture
gin7773 Aug 12, 2026
fd3e299
Corrected the state check in StopAndDestroy()
gin7773 Aug 12, 2026
1beebbe
fixed some review issues
gin7773 Aug 20, 2026
6b74187
Clean up FFI event port initialization
gin7773 Aug 21, 2026
bb93681
Fix seekTo completion
gin7773 Aug 21, 2026
630e3d4
Fix pending seekTo handing
gin7773 Aug 24, 2026
4db5a67
Update CHANGELOG
gin7773 Aug 24, 2026
c808844
Add native seek guard
gin7773 Aug 24, 2026
2b3d8ce
Merge branch 'main' into videohole/ffi_migration
gin7773 Sep 4, 2026
86d413f
Add LICENSE and remove unnecessary code
gin7773 Sep 10, 2026
bd3c6fb
Merge branch 'main' into videohole/ffi_migration
gin7773 Sep 10, 2026
806c17f
Rename manually maintained FFI bindings file and remove redundant code
gin7773 Sep 11, 2026
29b02a9
Merge branch 'main' into videohole/ffi_migration
gin7773 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/video_player_videohole/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
## 0.5.11

@JSUYA JSUYA Sep 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must not delete the 0.5.11 changelog.

## 0.6.0

* Replace ecore-wl2 code with tizen window manager plugin.
* Resolve `strict_top_level_inference` lint.
* Migrate from Platform Channels to Dart FFI.
* Replace EventChannel with FFI port for event callbacks.
* Add JSON serialization for complex parameters.
* Add pending seekTo handling.

## 0.5.10

Expand Down
2 changes: 1 addition & 1 deletion packages/video_player_videohole/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ To use this package, add `video_player_videohole` as a dependency in your `pubsp

```yaml
dependencies:
video_player_videohole: ^0.5.11
video_player_videohole: ^0.6.0
```

Then you can import `video_player_videohole` in your Dart code:
Expand Down
6 changes: 3 additions & 3 deletions packages/video_player_videohole/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class _HlsRomoteVideoState extends State<_HlsRomoteVideo> {
void initState() {
super.initState();
_controller = VideoPlayerController.network(
'https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8',
'https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8',
);

_controller.addListener(() {
Expand Down Expand Up @@ -388,7 +388,7 @@ class _TrackTestState extends State<_TrackTest> {
super.initState();

_controller = VideoPlayerController.network(
'https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8',
'https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8',
);

_controller.addListener(() {
Expand Down Expand Up @@ -761,7 +761,7 @@ class _TestRemoteVideoState extends State<_TestRemoteVideo> {
void initState() {
super.initState();
_controller = VideoPlayerController.network(
'https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8',
'https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8',
);

_controller.addListener(() {
Expand Down
Loading
Loading