sys-apps/ignition: pull 2.26.0 - #4229
Draft
tormath1 wants to merge 2 commits into
Draft
Conversation
This pulls the last release of Ignition 2.26.0 including a stabilization of Ignition spec (3.6) Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
There was a problem hiding this comment.
Pull request overview
Updates the Gentoo overlay packaging for sys-apps/ignition to the upstream 2.26.0 release, including patch rebases to align with the stabilized Ignition spec (notably 3.6/3.7-related adjustments) and updated vendoring.
Changes:
- Bump distfile to Ignition
2.26.0and add a newignition-2.26.0.ebuild. - Rebase/renumber the Flatcar patch stack for the new upstream release (including QEMU fw_cfg and OEM/oem-related patches).
- Drop some documentation/test patch files as noted in the PR description.
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/Manifest | Updates distfile entry/checksums for ignition-2.26.0.tar.gz. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/ignition-9999.ebuild | Updates patch list to the rebased/renumbered series. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/ignition-2.26.0.ebuild | Adds versioned ebuild for the 2.26.0 release using the updated patch stack. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0001-sed-s-coreos-flatcar.patch | Rebases “coreos → flatcar” mass-change patch to new upstream. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0002-config-add-ignition-translation.patch | Rebases ignition translation patch to new upstream. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0003-mod-add-flatcar-ignition-0.36.2.patch | Rebases Go module changes required for conversion tooling. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0004-config-v3_7-convert-ignition-2.x-to-3.x.patch | Moves conversion logic to v3.7 experimental config path. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0005-vendor-go-mod-vendor.patch | Updates vendored dependencies/modules list for the new version. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0006-internal-prv-cmdline-backport-flatcar-patch.patch | Rebases cmdline compatibility backport. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0007-provider-qemu-apply-fw_cfg-patch.patch | Rebases and extends QEMU fw_cfg provider logic for Flatcar/CoreOS paths. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0008-internal-disk-fs-ignore-fs-format-mismatches-for-the.patch | Rebases OEM filesystem formatting behavior adjustment. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0008-config-3_6-test-add-ignition-2.x-test-cases.patch | Removed documentation/test-only patch (as mentioned in PR description). |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0009-VMware-Fix-guestinfo.-.config.data-and-.config.url-v.patch | Rebases VMware guestinfo config handling patch to v3.7 types. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0010-config-version-handle-configuration-version-1.patch | Rebases version-detection patch. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0011-config-util-add-cloud-init-detection-to-initial-pars.patch | Rebases cloud-init/script detection patch. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0012-Partially-revert-drop-OEM-URI-support.patch | Rebases OEM URI support changes (adds oem:// fetch plumbing). |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0013-config-Support-oem-schema-in-newer-config-spec-versi.patch | Rebases oem:// scheme validation across newer config versions. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0014-translation-support-OEM-and-oem.patch | Rebases OEM/oem translation patch. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0015-usr-share-oem-oem.patch | Rebases /usr/share/oem → /oem lookaside changes. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0016-internal-exec-stages-mount-Mount-oem.patch | Rebases mount-stage OEM mount behavior patch. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0016-docs-Add-re-added-platforms-to-docs-to-pass-tests.patch | Removed documentation patch (as mentioned in PR description). |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0017-usr-share-oem-oem.patch | Removed older duplicate/overlapping /usr/share/oem → /oem patch. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0017-stages-disks-Fix-handling-of-device-mapper-when-part.patch | Rebases device-mapper partitioning handling fix. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0018-stages-disks-Fix-giving-partition-number-0-to-get-th.patch | Rebases partition-number allocation fix. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0019-stages-disks-Allow-partx-to-fail-then-check-the-stat.patch | Rebases partx failure handling improvements (plus related distro/exec changes). |
Suppressed comments (1)
sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0012-Partially-revert-drop-OEM-URI-support.patch:142
- Adding support for the
oemURL scheme makesfetchFromOEMreachable. In the same patch,fetchFromOEMcurrently doesfilepath.Join(distro.OEMLookasideDir(), path)after requiringpathto be absolute; in Go, joining with an absolute second argument discards the base, sooem:///etc/shadowwould resolve outside the OEM lookaside dir.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+87
to
+97
| + for cfgPath, sizePath := range firmwareConfigPaths { | ||
| + // get size of firmware blob, if it exists | ||
| + var sizeBytes []byte | ||
| + sizeBytes, err = os.ReadFile(sizePath) | ||
| + if os.IsNotExist(err) { | ||
| + f.Logger.Info("QEMU firmware config was not found. Ignoring...") | ||
| + continue | ||
| + } else if err != nil { | ||
| + f.Logger.Err("couldn't read QEMU firmware config size: %v", err) | ||
| + return | ||
| + } |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (1)
changelog/updates/2026-08-26-ignition.md:1
- The link for Ignition 2.25.1 points to the 2.26.0 anchor (
#ignition-2260-2026-02-17). It should use the 2.25.1 section anchor so the changelog doesn’t send readers to the wrong release notes.
- Ignition ([2.26.0](https://coreos.github.io/ignition/release-notes/#ignition-2260-2026-02-17) (includes [2.25.1](https://coreos.github.io/ignition/release-notes/#ignition-2260-2026-02-17), [2.25.0](https://coreos.github.io/ignition/release-notes/#ignition-2250-2025-12-11)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls the last release of Ignition 2.26.0 including a stabilization of Ignition spec (3.6)
As usual some gymnastics to adapt the patches but overall it was applying then. I'd say: let's see if the CI is green for all platforms.
I removed some documentations patches.
Closes: flatcar/Flatcar#2343