Set Android minSdkVersion 26 and react-native-webgpu 0.10.1 in fishjam-chat - #610
Merged
Merged
Conversation
react-native-webgpu uses AHardwareBuffer APIs from Android 8.0 (API 26), and Expo SDK 57 builds for API 24 by default, so a clean prebuild of the example failed to compile react-native-webgpu. Raise minSdkVersion with expo-build-properties, which the example already depends on.
0.10.1 releases the imported camera frame on GPUExternalTexture.destroy() (wcandillon/react-native-webgpu#478). On 0.5.15 every WebGPU camera effect leaks about one frame of graphics memory per frame on Android until the JS garbage collector runs (200 MB to 1 GB saw-tooth on a Galaxy S23).
MiloszFilimowski
changed the title
czerwiukk
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fishjam-chat now sets Android
minSdkVersionto 26 throughexpo-build-properties. The example already had that package in its dependencies but never configured it.Motivation and Context
After #606, a clean Android build of fishjam-chat fails:
react-native-webgpucallsAHardwareBufferAPIs that exist only from Android 8.0 (API 26). Expo SDK 57 builds for API 24 by default, and nothing in the example raised it. A build from an existingandroid/folder can still pass if that folder already had a higher minSdk.Checked on
main(fff4e57), arm64-v8a, withexpo prebuild --platform android --cleanand then./gradlew app:assembleDebug:BUILD SUCCESSFUL.Found while testing the React Native camera effects docs. The same step goes into those docs for apps that use
@fishjam-cloud/video-effects.react-native-webgpu 0.10.1
Second commit bumps
react-native-webgpufrom 0.5.15 to 0.10.1 in fishjam-chat and in the dev dependencies ofreact-native-custom-video-sourceandreact-native-vision-camera-source(peer ranges unchanged). 0.10.1 fixes a leak inGPUExternalTexture.destroy()(wcandillon/react-native-webgpu#478): on 0.5.15 every WebGPU camera effect holds about one camera frame of graphics memory per frame until the JS garbage collector runs, a 200 MB to 1 GB saw-tooth on a Galaxy S23; on 0.10.1 it stays flat at about 145 MB.tscpasses for both packages and the example against the new version.Note for apps on 0.8.4 or newer:
GPUTextureUsage,GPUShaderStageandGPUBufferUsageimported fromreact-native-webgpuareundefinedat import time (upstream evaluates them before its native install). Use the globals of the same name or plain numbers;@fishjam-cloud/video-effects0.1.5 does the latter.Documentation impact
Types of changes
not work as expected)