fix(react-native): use own WebGPU flag constants, release 0.1.5 - #9
Merged
Merged
Conversation
react-native-webgpu >= 0.8.4 evaluates its constants module before the native install runs, so GPUTextureUsage, GPUShaderStage and GPUBufferUsage imported from it are undefined and every camera effect failed with "Cannot read property 'TEXTURE_BINDING' of undefined". The values are fixed by the WebGPU spec, so use the package's own constants (core/constants.ts) like the web path already does.
MiloszFilimowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native-webgpu 0.8.4 and newer evaluates its
constantsmodule before the native install has run (main/index.tsxnow importsinstall.ts, which importsconstants.ts), soGPUTextureUsage,GPUShaderStageandGPUBufferUsageimported from the package areundefined. With react-native-webgpu 0.10.1 every camera effect failed at setup:The flag values are fixed by the WebGPU spec and the web path already uses our own
TEXTURE_USAGE/BUFFER_USAGEincore/constants.ts, so the React Native files now use those too (plus a newSHADER_STAGE). What remains from react-native-webgpu is theGPUSharedTextureMemorytype andWebGPUModule.Second commit bumps the version to 0.1.5 and the dev dependency to react-native-webgpu 0.10.1 (peer range stays
>=0.5.15; the package works on both).Verified on the iOS simulator with react-native-webgpu 0.10.1: blur and the docs' WebGPU tutorial effect run at 30 fps, footprint flat over 40 s.
yarn test(tsc, lint, prettier) passes against the 0.10.1 types.Why we want 0.10.1: it ships wcandillon/react-native-webgpu#478, which fixes the per-frame graphics memory leak on Android (200 MB to 1 GB saw-tooth with any camera effect on 0.5.15). The docs (fishjam-cloud/documentation#287) now require video-effects 0.1.5 and react-native-webgpu 0.10.1 together.
After merging:
gh release create v0.1.5 --title v0.1.5 --generate-notespublishes to npm through the release workflow.