Skip to content

Standardize Helm msmtp configuration path - #98

Merged
firefart merged 2 commits into
devfrom
copilot/fix-code-for-review-comment
Aug 27, 2026
Merged

Standardize Helm msmtp configuration path#98
firefart merged 2 commits into
devfrom
copilot/fix-code-for-review-comment

Conversation

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The Helm RT deployment mounted msmtp configuration outside msmtp’s default lookup path, unlike the CronJob and Docker Compose services. This prevented RT mail delivery when invoking /usr/bin/msmtp without -C.

  • Helm deployment
    • Mount the Secret at /etc/msmtprc, matching other services.
- name: msmtp-config
  mountPath: /etc/msmtprc
  subPath: msmtp.conf
  readOnly: true

Copilot AI changed the title [WIP] Fix code based on review comment Standardize Helm msmtp configuration path Aug 27, 2026
Copilot AI requested a review from firefart August 27, 2026 07:34
Copilot AI and others added 2 commits August 27, 2026 09:36
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: firefart <105281+firefart@users.noreply.github.com>
Co-authored-by: firefart <105281+firefart@users.noreply.github.com>
@firefart
firefart force-pushed the copilot/fix-code-for-review-comment branch from 652b898 to c7608a1 Compare August 27, 2026 07:36
@firefart
firefart marked this pull request as ready for review August 27, 2026 07:36
Copilot AI lite review requested due to automatic review settings August 27, 2026 07:36
@firefart
firefart merged commit 8c6d4cb into main Aug 27, 2026
10 checks passed
@firefart
firefart deleted the copilot/fix-code-for-review-comment branch August 27, 2026 07:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, consistent Helm mount-path adjustment with no detected conflicting references in the chart or repository.

Pull request overview

This PR aligns the Helm chart’s msmtp Secret mount with msmtp’s default config lookup path so /usr/bin/msmtp works without requiring -C, matching the behavior already used in other deployment modes.

Changes:

  • Update the RT Helm Deployment to mount the msmtp config Secret at /etc/msmtprc instead of /msmtp/msmtp.conf.
File summaries
File Description
helm/templates/deployment-rt.yaml Adjusts the msmtp config volumeMount path to /etc/msmtprc so msmtp can find its config by default.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants