Standardize Helm msmtp configuration path - #98
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Standardize Helm msmtp configuration path
Aug 27, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: firefart <105281+firefart@users.noreply.github.com>
Co-authored-by: firefart <105281+firefart@users.noreply.github.com>
firefart
force-pushed
the
copilot/fix-code-for-review-comment
branch
from
August 27, 2026 07:36
652b898 to
c7608a1
Compare
firefart
marked this pull request as ready for review
August 27, 2026 07:36
There was a problem hiding this comment.
🟢 Approval recommended
The change is a small, consistent Helm mount-path adjustment with no detected conflicting references in the chart or repository.
Pull request overview
This PR aligns the Helm chart’s msmtp Secret mount with msmtp’s default config lookup path so /usr/bin/msmtp works without requiring -C, matching the behavior already used in other deployment modes.
Changes:
- Update the RT Helm Deployment to mount the msmtp config Secret at
/etc/msmtprcinstead of/msmtp/msmtp.conf.
File summaries
| File | Description |
|---|---|
| helm/templates/deployment-rt.yaml | Adjusts the msmtp config volumeMount path to /etc/msmtprc so msmtp can find its config by default. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Helm RT deployment mounted msmtp configuration outside msmtp’s default lookup path, unlike the CronJob and Docker Compose services. This prevented RT mail delivery when invoking
/usr/bin/msmtpwithout-C./etc/msmtprc, matching other services.