FA-9911/add bank id to ACH rail - #263
Open
saraidy wants to merge 2 commits into
Open
Conversation
Required for PSE-routed Ach on-ramps (e.g. COP), where the provider needs the payer's bank identifier to build the correct PSE redirect. Since AchAddress and OnRampRequestFrom's Ach branch both derive from AchCapability, this makes bankId available on-ramp requests, off-ramp addresses, and on-ramp payment instructions without further changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
npm run make-unified-openapi / generate-openapi-client after the AchCapability.bankId change, per v2/api-validator/README.md's contributor workflow. Also picks up the AMOUNT_ABOVE_MAXIMUM enum value that FA-7791 added to the source spec but never regenerated into fb-unified-openapi.yaml / the generated client. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.