Converter for Baden-Württemberg, Germany - #216
Merged
Merged
Conversation
saidy-moregeo
marked this pull request as ready for review
August 25, 2026 08:19
saidy-moregeo
changed the title
ivorbosloper
approved these changes
Aug 28, 2026
Contributor
|
@saidy-moregeo Tests fail, weirdly only on Windows. Can you check the logs and see why this happens? I think from the error messages you can take corresponding actions without being on Windows. Thanks. |
saidy-moregeo
force-pushed
the
de-bw-converter
branch
from
August 31, 2026 09:21
2282d3a to
485a4cb
Compare
Collaborator
|
Looks good to me |
m-mohr
reviewed
Aug 31, 2026
|
|
||
| # read_geojson calls open() without an encoding, so it follows the platform locale: | ||
| # UTF-8 on Linux/macOS, cp1252 on Windows, which would turn "Grünland" into mojibake. | ||
| open_options = dict(encoding="utf-8") |
Contributor
There was a problem hiding this comment.
I suppose this is something we should enable by default for all converters?!
Collaborator
Author
There was a problem hiding this comment.
Yes - I would suggest to handle that on a separate PR.
Contributor
There was a problem hiding this comment.
Okay, please open an issue for it, assign it to you and work on it. Then you can squash merge this yourself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(GISELa LPIS reference parcels, 2018-2022)