Skip to content

Test queue message wrapping in @fedify/cfworkers - #1016

Merged
dahlia merged 1 commit into
fedify-dev:mainfrom
m2nsp:issue-877-test-queue-msg-wrapping-in-cfworkers
Aug 30, 2026
Merged

Test queue message wrapping in @fedify/cfworkers#1016
dahlia merged 1 commit into
fedify-dev:mainfrom
m2nsp:issue-877-test-queue-msg-wrapping-in-cfworkers

Conversation

@m2nsp

@m2nsp m2nsp commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Add a test for WorkersMessageQueue.enqueue() to verify that the queue binding receives the message wrapped with __fedify_ordering_key__ and __fedify_payload__.

Fixes #877

Test plan

  • mise run check-each cfworkers

AI disclosure

This change was written with assistance from Codex:gpt-5.6-luna, reviewed and verified by me.

@netlify

netlify Bot commented Aug 29, 2026

Copy link
Copy Markdown

Deploy Preview for fedify-json-schema canceled.

Name Link
🔨 Latest commit ddfb830
🔍 Latest deploy log https://app.netlify.com/projects/fedify-json-schema/deploys/6a93841bdae58f0008aded8b

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 441de3db-8bbd-497a-af42-38f5b8e183c9

📥 Commits

Reviewing files that changed from the base of the PR and between e682b83 and 73579fb.

📒 Files selected for processing (1)
  • packages/cfworkers/src/mod.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

Adds a WorkersMessageQueue.enqueue() test that verifies the queue binding receives the expected ordering key and payload wrapper fields.

Changes

Cloudflare Workers queue

Layer / File(s) Summary
Queue enqueue validation
packages/cfworkers/src/mod.test.ts
The test captures the message sent to the queue binding and verifies __fedify_ordering_key__ and __fedify_payload__.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 73579

This PR adds localized test coverage for existing queue message wrapping without changing runtime behavior or externally visible functionality. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: 2chanhaeng

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes add the requested WorkersMessageQueue.enqueue() test and verify fedify_ordering_key and fedify_payload in the queue binding message.
Out of Scope Changes check ✅ Passed The changes are limited to the requested test in packages/cfworkers/src/mod.test.ts. No unrelated changes are identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Title check ✅ Passed The title clearly identifies the added queue message wrapping test in @fedify/cfworkers.
Description check ✅ Passed The description accurately explains the test objective, expected fields, linked issue, and validation command.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dahlia dahlia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Assisted-by trailer in your commit message is improperly formatted:

Assisted-by: GPT-5.6 Luna

It should be like:

Assisted-by: Codex:gpt-5.6-luna

Assisted-by: Codex:gpt-5.6-luna
@m2nsp
m2nsp force-pushed the issue-877-test-queue-msg-wrapping-in-cfworkers branch from 73579fb to ddfb830 Compare August 30, 2026 01:15
@m2nsp
m2nsp requested a review from dahlia August 30, 2026 01:19
@dahlia dahlia self-assigned this Aug 30, 2026
@dahlia dahlia added the runtime/cfworkers Cloudflare Workers runtime related label Aug 30, 2026
@dahlia dahlia added this to the Fedify 2.4 milestone Aug 30, 2026
@dahlia
dahlia merged commit 81416ae into fedify-dev:main Aug 30, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

runtime/cfworkers Cloudflare Workers runtime related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test queue message wrapping in @fedify/cfworkers

2 participants