fix: allow creating empty sessions - #303
Open
lprnmns wants to merge 1 commit into
Open
Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
lprnmns
marked this pull request as ready for review
August 31, 2026 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FastifyInstance.createSecureSession(data?) is declared with optional data in types/index.d.ts and is exercised without an argument in the TypeScript tests. At runtime, calling createSecureSession() throws while Session initializes its timestamp, so integrations that need an empty session cannot use the public helper.
Fix
Default omitted data to an empty object at the createSecureSession decorator boundary. Existing object arguments are unchanged, and the regression assertion confirms the returned empty session is usable.
Tests
Compatibility
This changes only the previously failing omitted or undefined-data case to match the existing optional TypeScript contract. Sessions created with an object retain their current behavior.
Related issue
Independent reproduction; no issue linked.