fix inconsistent syntax highlighting for field of type inspect._ParameterKind #4751 - #4794
Open
asukaminato0721 wants to merge 2 commits into
Open
asukaminato0721 wants to merge 2 commits into
asukaminato0721 wants to merge 2 commits into
Conversation
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D118576862. (Because this pull request was imported automatically, there will not be any future comments.) |
This comment has been minimized.
This comment has been minimized.
kinto0
requested changes
Sep 9, 2026
kinto0
left a comment
kinto0
left a comment
Contributor
There was a problem hiding this comment.
I don't love this special-case. until now, all attributes could be colored based on only their type. is this the only exception? Is it true that accessed_on_class + being an enum are the only qualifiers?
asukaminato0721
force-pushed
the
4751
branch
from
September 9, 2026 01:00
b14a160 to
754c9d4
Compare
This comment has been minimized.
This comment has been minimized.
asukaminato0721
force-pushed
the
4751
branch
from
September 10, 2026 05:33
754c9d4 to
75e597a
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4751
fixes incorrect semantic highlighting for narrowed enum instance attributes.
Previously, holder.kind could be classified as an enumMember after narrowing.
Now instance attributes such as holder.kind remain property, actual enum members accessed through the enum class, such as E.A, remain enumMember.
Test Plan
add test