fix(utils): allow MDX to detect title when a component is exported before h1 - #12335
Open
jibin7jose wants to merge 1 commit into
Open
fix(utils): allow MDX to detect title when a component is exported before h1#12335jibin7jose wants to merge 1 commit into
jibin7jose wants to merge 1 commit into
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
This PR fixes a bug where Docusaurus fails to detect the title of an MDX page if a React component is
exported before the first<h1>heading. The regex inparseMarkdownContentTitlewas updated to properly strip outexportstatements (in addition toimportstatements) before looking for the title.Closes #12331
Test Plan
markdownUtils.test.tsto verify parsing works correctly when anexportblock precedes the<h1>title.