-
Notifications
You must be signed in to change notification settings - Fork 1
Fix registry/cosign/upgrade metadata + USER-gate authoring guide — PR #177 Majors #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
15df9e4
docs: fix registry/cosign/upgrade metadata and the USER-gate authorin…
jgruber b30f09f
review fix: MIN_UPGRADE_FROM must name a real tag; cosign identity is…
jgruber db83511
review fix: make 'merged' a real roadmap status key; regenerate; fix …
jgruber 00249f8
docs: correct the v3.1.6 changelog, the cosign verify prose, and the …
jgruber b9a6f24
docs(install-guide): public registry (no login) + settable admin pass…
jgruber 9720878
docs(install-guide): correct the MCP_PASSWORD guidance for the no-def…
jgruber abbc777
fix: install guide points at real tags; qualify the cosign claim; tri…
jgruber 49e0d3a
docs: CHANGELOG upgrade note for MCP_SERVICE_PASSWORD; fix dist 404 d…
jgruber ad2a790
docs(install-guide): correct First-login and MCP creds to this tree
jgruber a84ead1
docs+dist: align USER guidance, fix dist 404 class, upgrade prereqs, …
jgruber a93d51f
docs: make MCP boot-refusal a forward-looking 4.0.0/#188 note; fix MC…
jgruber ee20de0
docs: fix inert MCP_SERVICE_PASSWORD upgrade step, disclose seeded mc…
jgruber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -550,7 +550,9 @@ def is_root_user(image_user: str | None) -> bool: | |
| An image that never declares USER reports an empty string and runs as | ||
| root — that is the common case and must be caught. | ||
|
|
||
| Closes the numeric bypass only — see the KNOWN GAP note in the body. | ||
| Fails closed on anything that is not a bare non-zero decimal uid, | ||
| which also subsumes the named-alias case (see the body) — there is no | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checked this rather than taking it at face value, since "there is no remaining KNOWN GAP" is a strong claim to put in a security docstring. It holds:
The named-alias case really is subsumed. Good change. |
||
| remaining KNOWN GAP. | ||
|
|
||
| Only the uid half decides this. Docker's USER is ``<user>[:<group>]``, | ||
| so an image declaring ``USER 0:100`` or ``USER root:wheel`` runs as uid 0 | ||
|
|
@@ -647,7 +649,8 @@ def _fail(message: str, stdout: str = "") -> StepResult: | |
| f"Artifact image {spec.image_digest} runs as root " | ||
| f"(USER={image_user or '<unset>'}). Refusing to start it: the workspace is " | ||
| f"mounted from the host, so a root container is a host-root write primitive. " | ||
| f"Rebuild the image with a NUMERIC non-root USER (e.g. `USER 65532`). " | ||
| f"Rebuild the image with a NUMERIC non-root USER — `USER 1000` matches " | ||
| f"the workspace owner (chowned 1000:1000), so the step can write it. " | ||
| f"A named user is refused because it cannot be resolved to a uid " | ||
| f"without the image's own /etc/passwd — `USER toor` may well be uid 0. " | ||
| f"The Kubernetes substrate already enforces this: runAsNonRoot is " | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the part that matters, more than the
MIN_UPGRADE_FROMrevert itself -- the inherited "v3.0.1 pins cryptography 44 and staging is on 50" paragraph was a specific, confident claim about a tree this repo can't reach, and it's what sent this PR at a tag that doesn't exist. Recording the squashed-mirror constraint means the next person reads why the window is one release wide instead of trying to widen it the same way.CI agrees:
P2 · Migration Upgrade From Released Version (Postgres)is back toCOMPLETED/SUCCESS.