Skip to content

test(config): rename legacy IP fixture - #3437

Merged
tac0turtle merged 1 commit into
evstack:mainfrom
wangjingshuiku:test/config-legacy-ip-name
Aug 31, 2026
Merged

test(config): rename legacy IP fixture#3437
tac0turtle merged 1 commit into
evstack:mainfrom
wangjingshuiku:test/config-legacy-ip-name

Conversation

@wangjingshuiku

@wangjingshuiku wangjingshuiku commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Overview

Rename the misspelled legactIP test fixture to legacyIP in the P2P address validation cases. This is a test-only readability improvement with no behavior change.

Summary by CodeRabbit

  • Tests
    • Corrected a test variable name for improved clarity.
    • No functional or behavioral changes.

Signed-off-by: wangjingshuiku <wangjingshuiku@163.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 33439c40-89c6-4392-91ec-769dc8cd4a29

📥 Commits

Reviewing files that changed from the base of the PR and between 670af4e and 600a1b7.

📒 Files selected for processing (1)
  • pkg/config/addr_test.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change corrects the local variable name legactIP to legacyIP in TestTranslateAddresses and updates its three references. Test behavior remains unchanged.

Changes

Address test cleanup

Layer / File(s) Summary
Rename address test variable
pkg/config/addr_test.go
Renames legactIP to legacyIP and updates the listen-address, seed-address, and invalid-seed-address test cases.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 600a1

This test-only rename improves readability without changing production behavior or test semantics; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required Overview section and clearly states the change, scope, rationale, and absence of behavior changes.
Title check ✅ Passed The title is concise, follows the conventional commit format, and accurately describes the test fixture rename.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tac0turtle
tac0turtle merged commit 22417ad into evstack:main Aug 31, 2026
6 checks passed
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.27%. Comparing base (670af4e) to head (600a1b7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3437      +/-   ##
==========================================
- Coverage   69.28%   69.27%   -0.01%     
==========================================
  Files         121      121              
  Lines       11948    11948              
==========================================
- Hits         8278     8277       -1     
- Misses       3670     3671       +1     
Flag Coverage Δ
combined 69.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants