Fix numeric sorting in dashboard standings - #1825
Open
bensynapse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I maintain Live Tennis API.
Fixes #1294.
The API returns points as decimal strings, and both existing comparisons sorted them as text, placing
9above12. Use one numeric comparison for the Points/Elo columns, preserve the order of equal scores, and sort a copy before applying the row limit. The Name header now comparesteam.nameinstead of a missing field on the standings input.Validation:
cd frontend && pnpm testpasses (TypeScript and formatting).docker build --file frontend/Dockerfile frontendpasses. The build emits Vite configuration/plugin and bundle-size warnings.To reproduce the reported case, load a round-robin stage with point totals
9,12,11, and10: the initial order is now12, 11, 10, 9, and clicking Points reverses it numerically. Backend/database integration was not exercised.