add better-auth-eve-online, fix localisprimary/esi github attribute - #311
add better-auth-eve-online, fix localisprimary/esi github attribute#311Nfinished wants to merge 5 commits into
Conversation
| maintainer: | ||
| name: Tujiko Noriko | ||
| github: localisprimary | ||
| repository: https://github.com/localisprimary/esi |
There was a problem hiding this comment.
Is this correct? this would make it a clone of localisprimary/esi.
There was a problem hiding this comment.
It's not correct, because the repository field exists as a fallback for people not using GitHub or GitLab which have dedicated fields. This should be removed. (And also, this should point at the maintainer, not the project)
The field name is misleading though, maybe it should be called user-profile or something.
There was a problem hiding this comment.
ah oops, I missed this line in the copypaste from the other local is primary package. fixed.
There was a problem hiding this comment.
@Nohus so I should use my personal github profile even though the repo lives in the Local Is Primary org?
There was a problem hiding this comment.
No, what you have is already correct with name and github, just remove the repository field. That's meant for people who can't use the github field because they don't use GitHub. But you do use GitHub, so the repository field is not for you.
|
An issue I am seeing now is that https://github.com/localisprimary/better-auth-eve-online seems to have been created 5 hours ago. Does it pass the rule 5?
|
|
I guess not strictly, I'm publishing it now to open source a component of Upwell |
|
I don't mind revisiting this later if you'd feel better about it |
|
It would be fair to others to wait a bit then, please reopen the PR when 3 months have passed! |
3 participants
@localisprimary/better-auth-eve-online powers www.upwell.gg