gh: turn on Codecov identity-token upload path - #674
Closed
xdelaruelle wants to merge 1 commit into
Closed
Conversation
The no-token upload path lets Codecov verify a run through a GitHub Actions identity token, but codecov-action only requests that token when its own opt-in input for it is enabled, and the job running the step needs the id-token permission to obtain the token in the first place. Neither was set, so the action fell back to a legacy PR-label identification method that Codecov rejects with a "Token required" error. Grant id-token: write and turn on that opt-in input on the jobs that upload coverage. Assisted-by: Claude:claude-sonnet-5 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codecov-actiononly requests it when its own opt-in input is enabled, and the job needsid-token: writeto obtain the token at all. Neither was set, so uploads failed withToken required - not valid tokenless uploadon every run (confirmed by rerunning the last main commit and PR ts: cover remaining tcl/ line-coverage gaps #673).id-token: writeand turns on that opt-in input on the jobs that upload coverage inlinux_tests.yamlandmacos_tests.yaml.