Skip to content

fix: make Jira comment replies notify the author - #75

Merged
Hinne1 merged 4 commits into
mainfrom
claude/atl-safe-comment-replies
Sep 2, 2026
Merged

fix: make Jira comment replies notify the author#75
Hinne1 merged 4 commits into
mainfrom
claude/atl-safe-comment-replies

Conversation

@Hinne1

@Hinne1 Hinne1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Jira issue comments are flat. This changes --reply-to from copying the original comment into a blockquote to creating a real ADF mention of the original author plus a focused-comment link. It also documents Markdown link and mention syntax.

Verification:

  • go test ./internal/cmd/issue/comment ./internal/api
  • go test ./...

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the --reply-to flag behavior when adding a Jira issue comment. Instead of quoting the original comment, it now creates a flat comment that mentions the original author and includes a direct link to the original comment. Documentation in AGENTS.md and README.md has been updated, and unit tests have been added to verify the new ADF generation logic. I have no feedback to provide.

@Hinne1

Hinne1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the blockquote-based quoting mechanism for Jira comment replies with a flat reply structure. Replying to a comment using --reply-to now creates a flat comment that mentions the original author and links directly to the original comment instead of copying its content. This change simplifies the codebase by removing the obsolete quoting logic and tests, while introducing new unit tests for the flat reply construction. The reviewer suggested extracting magic strings and formats used in the reply header into package-level constants to improve maintainability.

Comment thread internal/cmd/issue/comment/add.go Outdated
@Hinne1

Hinne1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the previous comment quoting mechanism with a flat reply format that mentions the original author and links directly to the focused comment. The changes include removing the old quoting logic, implementing BuildReplyADF to construct the new reply structure, updating the CLI command and documentation, and adding new unit tests. The feedback suggests adding a test case to verify behavior when the author object is nil, which would further improve test coverage.

Comment thread internal/api/reply_adf_test.go
@Hinne1

Hinne1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes how comment replies are handled in the Jira CLI. Instead of quoting the original comment, replies are now created as flat comments that mention the original author and link to the original comment using the new BuildReplyADF function. The old quoting logic (QuoteADF) and its tests have been removed, and command documentation, help text, and tests have been updated accordingly. There are no review comments, so we have no feedback to provide.

@Hinne1

Hinne1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

🔏 Readiness attested — the pr-readiness-check gate completed for PR #75 at 4b143b3c26771fe0ecf51a2d302bae0c2eb58dcf (2026-09-02T07:59:04Z). If the branch head has moved, this evidence covers the earlier state only.

Composed by the readiness agent, posted under my account.

Readiness summary

PR Readiness Check — atl-cli #75

  • Head: 4b143b3c26771fe0ecf51a2d302bae0c2eb58dcf
  • Review mode: INITIAL
  • Branch/base: PASS — claude/atl-safe-comment-replies targets main; clean worktree and remote head match verified
  • Local verification: PASS — goimports -w ., git diff --check, targeted tests, pinned golangci-lint (0 issues), and go test -v -race ./...
  • Remote CI: DEFERRED UNTIL READY — current-head CodeQL passed; the Go workflow skips lint, test, build, and coverage while the PR is a draft
  • Coverage: DEFERRED UNTIL READY
  • Automated reviewer: PASS — Gemini reviewed the exact head and reported no feedback
  • Review threads: PASS — 0 unresolved
  • Council: DISPOSITIONED — three allowed rounds completed; actionable round-one and round-two findings were fixed, and the sole round-three Minor suggestion was retained as advisory. No Critical or Important findings remain deferred.
  • PR description: PASS
  • SQL/UI evidence: SKIP — CLI behavior is covered by unit and mocked HTTP transport tests

Result: READY

@Hinne1
Hinne1 marked this pull request as ready for review September 2, 2026 07:59
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/enthus-appdev/atl-cli/internal/api 41.12% (+0.02%) 👍
github.com/enthus-appdev/atl-cli/internal/cmd/issue/comment 27.91% (+1.09%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/enthus-appdev/atl-cli/internal/api/adf_quote.go 0.00% (-96.00%) 0 (-25) 0 (-24) 0 (-1) 💀 💀 💀 💀 💀
github.com/enthus-appdev/atl-cli/internal/api/reply_adf.go 94.12% (+94.12%) 17 (+17) 16 (+16) 1 (+1) 🌟
github.com/enthus-appdev/atl-cli/internal/cmd/issue/comment/add.go 39.66% (+4.27%) 58 (-7) 23 35 (-7) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/enthus-appdev/atl-cli/internal/api/adf_quote_test.go
  • github.com/enthus-appdev/atl-cli/internal/api/jira_comment_body_test.go
  • github.com/enthus-appdev/atl-cli/internal/api/reply_adf_test.go

@Hinne1
Hinne1 merged commit 5c940e8 into main Sep 2, 2026
15 checks passed
@Hinne1
Hinne1 deleted the claude/atl-safe-comment-replies branch September 2, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant