fix: make Jira comment replies notify the author - #75
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the --reply-to flag behavior when adding a Jira issue comment. Instead of quoting the original comment, it now creates a flat comment that mentions the original author and includes a direct link to the original comment. Documentation in AGENTS.md and README.md has been updated, and unit tests have been added to verify the new ADF generation logic. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request replaces the blockquote-based quoting mechanism for Jira comment replies with a flat reply structure. Replying to a comment using --reply-to now creates a flat comment that mentions the original author and links directly to the original comment instead of copying its content. This change simplifies the codebase by removing the obsolete quoting logic and tests, while introducing new unit tests for the flat reply construction. The reviewer suggested extracting magic strings and formats used in the reply header into package-level constants to improve maintainability.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request replaces the previous comment quoting mechanism with a flat reply format that mentions the original author and links directly to the focused comment. The changes include removing the old quoting logic, implementing BuildReplyADF to construct the new reply structure, updating the CLI command and documentation, and adding new unit tests. The feedback suggests adding a test case to verify behavior when the author object is nil, which would further improve test coverage.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request changes how comment replies are handled in the Jira CLI. Instead of quoting the original comment, replies are now created as flat comments that mention the original author and link to the original comment using the new BuildReplyADF function. The old quoting logic (QuoteADF) and its tests have been removed, and command documentation, help text, and tests have been updated accordingly. There are no review comments, so we have no feedback to provide.
|
🔏 Readiness attested — the Composed by the readiness agent, posted under my account. Readiness summaryPR Readiness Check — atl-cli #75
Result: READY |
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Jira issue comments are flat. This changes --reply-to from copying the original comment into a blockquote to creating a real ADF mention of the original author plus a focused-comment link. It also documents Markdown link and mention syntax.
Verification: