feat(cli): thread Config into the resume path - #203
Draft
ecalifornica wants to merge 1 commit into
Draft
Conversation
|
🔍 Preview deployed: https://a2f1a962.toolpath.pages.dev |
ecalifornica
force-pushed
the
robert/config-resume
branch
from
August 14, 2026 19:49
5bf1c9e to
f439427
Compare
ecalifornica
marked this pull request as ready for review
August 17, 2026 17:01
ecalifornica
force-pushed
the
robert/config-resume
branch
from
August 18, 2026 20:09
f439427 to
7754dcd
Compare
`resume` receives `&Config` from run() and passes it to the input resolver and the projectors. The transitional `Config::load()` calls in `run_with_strategy` and `resolve_input` are gone. - `cmd_resume::run`, `run_with_strategy`, and `resolve_input` take `&Config`. The Pathbase fetch calls `derive::pathbase_fetch_to_doc(config, …)`. - `Config` is public and `config` is a public module. `run_with_strategy` is the public entry point for `tests/resume.rs`, so its parameter type must be nameable there. The public items are `#[doc(hidden)]` and the fields stay crate-private; `Config::load` is the only constructor outside the crate. - The `$PATH` read for the harness binary lookup stays. A binary lookup is execution environment, not configuration. - The `project_into_harness` unit test injects a `Config` rooted at a tempdir. The `run_with_strategy` unit test does the same and keeps the `$PATH` guard. - The `resolve_input` unit tests inject a `Config`. The Pathbase fetch test needs no environment guard. The cache-hit test and the unresolvable-input test still set `$TOOLPATH_CONFIG_DIR`, because `cache.rs` reads it. - `ScopedHomeForResume` is deleted. The unit tests set no `$HOME`. - `ScopedHome::config` gives the integration tests the `Config` the CLI extracts at its composition root.
ecalifornica
force-pushed
the
robert/config-resume
branch
from
August 25, 2026 20:23
7754dcd to
3267c12
Compare
ecalifornica
marked this pull request as draft
August 25, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #184; path-cli only.
cmd_resumetakes&Config(3 signatures), and the projectors and the Pathbase fetch receive the oneConfigextracted inrun().Configand theconfigmodule arepuband#[doc(hidden)]with crate-private fields, becauserun_with_strategyis the entry pointtests/resume.rsdrives.$PATHstays a live read: a binary lookup is execution environment, not configuration. The cache PR owns the remaining$TOOLPATH_CONFIG_DIRread underresolve_input, so the integration tests keepScopedHomeand passScopedHome::config().