ci: fix mix format --check-formatted in lib/package/macos.ex - #19
Merged
Conversation
The host-driven BEAM restart commit (#18) introduced a `case` clause in `Desktop.Deployment.Package.MacOS.release/1` that the current formatter rewrites with blank lines between branches. The CI `mix lint` alias runs `format --check-formatted`, which has been failing on main since #18. Reformat the `case` so the file passes the formatter check. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mix lintfails onmainbecauselib/package/macos.exis not formatted.The
release/1caseintroduced in #18 uses a one-line branch form. Thecurrent
mix formatrewrites it with blank lines between branches, soformat --check-formatted(run by thelintalias) rejects the file.Reformat the file so
mix lintpasses in CI.Test plan
mix format --check-formattedpasses locallymix lint(format + credo) passes locallytest mix.create_keychainworkflow passes on this PRCloses the failing CI on main.
Made with Cursor