Codex: warn and skip clones that the token cannot access - #3974
Merged
Conversation
A missing clone token policy must not fail the whole Codex publish job. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/3974/ |
theletterf
approved these changes
Aug 31, 2026
Mpdreamz
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs-builder codex clonewarns and skips a repository when the clone token cannot read it. The rest of the Codex publish job continues.Affects: Codex builds
Why
A Codex repository can land in the link index before the clone token policy grants read access.
codex clonealready catches that failure and emits a warning. After docs-builder 1.42.0, git still records collector errors for the failed fetch, so the warning path does not save the job. One missing policy then stops the whole Codex publish.What
Isolated git diagnostics
Clone git work writes errors to a local collector, not the job collector. The job still sees the existing warning and skip. Assembler clone behaviour does not change.
Failed fetch and checkout
A failed
FetchorCheckoutthrows after retries instead of continuing intorev-parse. The catch inCodexCloneServiceturns that into a warning.Empty checkouts after a skip
DiscoverCheckoutsskips a repository whose.githas no HEAD. A failed clone no longer breaks the latercodex buildstep.Verify
Out of scope: This PR does not add
elastic/amer-fed-education-docsto the clone token policy. That repo still stays unpublished until the policy exists.Made with Cursor