New fieldtype - #10
Open
elabx wants to merge 16 commits into
Open
Conversation
…putfieldRecurringDatesRule.js
…ule.module to handle empty values and improve settings initialization. Added checks for valid rrule and settings before saving. Updated comments for clarity.
Enhance InputfieldRecurringDatesRule.js and InputfieldRecurringDatesR…
… to ensure compatibility with missing elements. Added null checks for rrule and settings data retrieval.
…ngDatesRule.module to handle empty values and improve settings initialization. Added checks for valid rrule and settings before saving. Updated comments for clarity." This reverts commit 14b3a97.
…ule.module to handle null and empty values more robustly. Added checks for settings and rrule initialization, ensuring defaults are set when necessary. Updated comments for better clarity.
…ttributes for better data handling
…in FieldtypeRecurringDatesRule for improved version handling
…m FieldtypeRecurringDatesRule and InputfieldRecurringDatesRule, streamlining the code for better performance and clarity.
The "Days of the week" filter listed Sunday first with no way to change it. It now starts on Monday, and a "First day of the week" select in the field's input config lets it start on Sunday instead. The setting is passed to Alpine via data-week-start, which rotates the list on init. This affects the display order only, not the rule's WKST property. Also drop the hardcoded ?v=123 on the JS URL: versionUrls() leaves any URL that already has a query string alone, so the URL never changed and browsers kept serving cached JS. Pass true for a filemtime based version, since the default only changes with the core version when debug is off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New RRule fieldtype that only saves the rule.