Skip to content

test(egg-bin): prevent dependency install scripts - #6047

Closed
fengmk2 wants to merge 1 commit into
nextfrom
fix/egg-bin-no-install-scripts
Closed

test(egg-bin): prevent dependency install scripts#6047
fengmk2 wants to merge 1 commit into
nextfrom
fix/egg-bin-no-install-scripts

Conversation

@fengmk2

@fengmk2 fengmk2 commented Aug 23, 2026

Copy link
Copy Markdown
Member

@eggjs/bin does not define dependency install scripts. This change documents that behavior. It also adds a regression test for preinstall, install, and postinstall.

Package managers do not need an install-script allowlist entry for @eggjs/bin.

The focused test and the full @eggjs/bin test suite pass.

Closes eggjs/bin#294.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a502954-1b7a-4f30-a665-98f7e5c72f13

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fengmk2 fengmk2 closed this Aug 23, 2026
@fengmk2
fengmk2 deleted the fix/egg-bin-no-install-scripts branch August 23, 2026 07:12
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.50%. Comparing base (d4129fc) to head (5938ad7).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #6047      +/-   ##
==========================================
- Coverage   83.08%   78.50%   -4.58%     
==========================================
  Files         731       18     -713     
  Lines       22496      842   -21654     
  Branches     4530      227    -4303     
==========================================
- Hits        18690      661   -18029     
+ Misses       3299      153    -3146     
+ Partials      507       28     -479     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm RFC #868 will block this package's install script by default

1 participant