Feat/cdse dashboard bar fixes - #76
Conversation
…ashboard Remove the +N number labels from the onboarding history bar chart (values are still available via tooltip on hover). Switch the default aggregation mode from daily to weekly for a cleaner overview.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3375c8df8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const weekly = {} | ||
| for (const d of deltas) { | ||
| // Year-prefixed so the sort stays correct across a year boundary | ||
| const key = d.date.slice(0, 4) + "-W" + String(getWeekNumber(d.date)).padStart(2, "0") |
There was a problem hiding this comment.
When odataHist spans a New Year, this key combines the calendar year with a non-ISO week number, so dates from the same ISO week are split and mislabeled across multiple bars (for example, 2026-12-28 through 2027-01-03 becomes 2026-W53, 2027-W01, and 2027-W02). Because the chart now defaults to weekly and the code intends to sum deltas per ISO week, the dashboard will show incorrect weekly totals around year boundaries; derive both the ISO week number and ISO week-year from the date instead.
Useful? React with 👍 / 👎.
2 participants
No description provided.