Variants from models endpoint - #580
Merged
Merged
Conversation
zikajk
commented
Aug 31, 2026
zikajk
commented
Member
- I added a entry in changelog under unreleased section.
- This is not an AI slop.
zikajk
force-pushed
the
variants-from-models-endpoint
branch
3 times, most recently
from
August 31, 2026 06:21
4cb3245 to
0fcf578
Compare
When a generic /models entry advertises reasoning efforts and neither
built-in nor user variants exist for the model, build variants from
them. Both the OpenRouter shape (`reasoning.supported_efforts`) and
the Synthetic shape (`reasoning_parameters.efforts`) are accepted.
openai-chat maps each effort to `reasoning_effort`, openai /
openai-responses maps to `reasoning.effort` + `summary auto`. APIs
whose effort payload can't be mapped faithfully (anthropic, bedrock)
build nothing, so users configure variants manually there. User
variants still merge on top and `{}` removes individual variants.
Since 0.157.1 the anthropic adapter enriches provider errors before delivery (error.type/error.message from the structured body are parsed into :code and a rewritten :message), but this test still expected the raw error, so it fails on master. Expect the delivered, enriched error instead.
zikajk
force-pushed
the
variants-from-models-endpoint
branch
from
August 31, 2026 06:41
0fcf578 to
29a419b
Compare
Commit 98da790 added the /delete-chat native command without updating this test's expected command lists, so every integration run fails on both query assertions (already red on master CI). Add delete-chat with its chat-id argument in the position the server reports it.
MCP prompts are listed after the server reports running, in a second tool/serverUpdated notification. The test queried commands right after the running notification, racing the prompt listing; on slow hosts (Windows CI) the query could miss the prompt command. Await the notification that carries prompts before querying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.