Fix afterAcquire hook failure leaking connection lease and metrics - #1699
Merged
Merged
Conversation
When the afterAcquire hook returns a failed future in SqlConnectionPool.PoolRequest.complete(), the lease is never recycled, dequeueMetric is never called, and the wrong error is propagated. Extract a fail(lease, cause) helper that recycles the lease, dequeues the metric, and fails the handler. Use it for both the afterAcquire failure path and the existing pool failure path. Assisted-by: Anthropic Claude (Opus 4.6) Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1698
When the
afterAcquirehook returns a failed future inSqlConnectionPool.PoolRequest.complete(), the lease is never recycled,dequeueMetricis never called, and the wrong error is propagated.Extract a
fail(lease, cause)helper that recycles the lease, dequeues the metric, and fails the handler. Use it for both theafterAcquirefailure path and the existing pool failure path.Assisted-by: Anthropic Claude (Opus 4.6)