Fix ASR propagation and documentation rendering - #442
Open
vishwajitdandage wants to merge 1 commit into
Open
Conversation
…and update requirements handling
vishwajitdandage
requested review from
LittleHuba,
castler,
hoe-jo,
limdor and
ramceb
as code owners
August 25, 2026 05:10
vishwajitdandage
changed the title
LittleHuba
reviewed
Aug 27, 2026
Comment on lines
+99
to
+111
| assumed_srcs_from_deps = [ | ||
| dep[AssumedSystemRequirementsInfo].srcs | ||
| for dep in ctx.attr.deps | ||
| if AssumedSystemRequirementsInfo in dep | ||
| ] | ||
| if assumed_srcs_from_deps: | ||
| assumed_provider = AssumedSystemRequirementsInfo( | ||
| srcs = depset(transitive = assumed_srcs_from_deps), | ||
| name = ctx.label.name, | ||
| is_transitive = True, | ||
| ) | ||
| else: | ||
| assumed_provider = None |
Contributor
There was a problem hiding this comment.
I don't think that merging these into the feature requirements is a good idea.
That would mix levels of requirements and make it complex for users to separate them once more.
I'm leaning towards creating an additional provider for this.
Can this fix wait some time for @hoe-jo to be back from vacation? I'd like to have his input on this as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Assumed System Requirements referenced by feature requirements must remain available for derived_from traceability. However, propagating them as regular ASR providers causes the documentation generator to render them as standalone Assumed System pages.
What Changed
Propagate ASR data through feature requirements for traceability.
Mark propagated ASR providers as transitive.
Ignore transitive ASR providers when generating standalone Assumed System documentation.
This preserves traceability while preventing feature requirements from being incorrectly rendered under Assumed System.