Upgrade to score_lifecycle 0.5.0 - #197
Merged
NEOatNHNG merged 3 commits intoAug 28, 2026
Merged
Conversation
NicolasFussberger
had a problem deploying
to
workflow-approval
August 28, 2026 06:13 — with
GitHub Actions
Error
NicolasFussberger
had a problem deploying
to
workflow-approval
August 28, 2026 06:13 — with
GitHub Actions
Error
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
NEOatNHNG
approved these changes
Aug 28, 2026
NEOatNHNG
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me in general. Thank you @NicolasFussberger for also updating baselibs for us. The only thing that we should check whether the removal of py_unittest_qnx_test has any impact on us (was also previously only an empty stub in baselibs). Can you confirm that it is OK to remove @lavrovvalera @BjoernAtBosch ?
NicolasFussberger
marked this pull request as ready for review
August 28, 2026 08:00
Contributor
|
Guess we doubled the work #198 :D |
Contributor
This was referenced Aug 28, 2026
BjoernAtBosch
approved these changes
Aug 28, 2026
BjoernAtBosch
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I think, the "py_unittest_qnx_test stuff" can be removed as those test are anyway triggered via cc_test and similar rules
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades time to score_lifecycle 0.5.0
Note:
The lifecycle bazel module was renamed score_lifecycle_health (last release 0.4.0) -> score_lifecycle (first release 0.5.0)
The switch from score_lifecycle_health 0.4.0 to score_lifecycle to 0.5.0 has no changes other than the module rename.
Updating to score_lifecycle 0.5.0 required updating to baselibs 0.2.12 first.
Feel free to close this PR and do the migration step by step: