chore: Bump devcontainer to 1.11.0, use KVM and docker-in-docker feature - #312
Merged
lurtz merged 1 commit intoAug 28, 2026
Merged
Conversation
With that `bazel test --lockfile_mode=error --config=linux-x86_64 //feature_integration_tests/itf` works. `bazel --output_base=build/linux-x86_64 run --config linux-x86_64 //images/linux_x86_64:run` for which the bind mount of the Docker socket was added, works as well.
lurtz
marked this pull request as ready for review
August 27, 2026 15:17
lurtz
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix,
nradakovic,
opajonk and
pawelrutkaq
as code owners
August 27, 2026 15:17
|
The created documentation from the pull request is available at: docu-html |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the development container to support KVM workloads and an isolated Docker daemon.
Changes:
- Upgrades the devcontainer image to v1.11.0.
- Adds KVM access and Docker-in-Docker.
- Pins the Docker-in-Docker feature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Configures the upgraded image, KVM, and Docker-in-Docker. |
.devcontainer/devcontainer-lock.json |
Locks the Docker-in-Docker feature version and digest. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "--device=/dev/kvm" | ||
| ], | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker": { |
AlexanderLanin
approved these changes
Aug 28, 2026
AlexanderLanin
left a comment
AlexanderLanin
left a comment
Member
There was a problem hiding this comment.
@lurtz please judge AI feedback yourself
Contributor
Author
I judge it as confused or my grammer in the PR description is confusing |
lurtz
deleted the
bump-devcontainer-and-use-kvm-and-docker-in-docker-feature
branch
August 28, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With that
bazel test --lockfile_mode=error --config=linux-x86_64 //feature_integration_tests/itfworks.bazel --output_base=build/linux-x86_64 run --config linux-x86_64 //images/linux_x86_64:runfor which the bind mount of the Docker socket was added, works as well.