Adds record_property in tests for req traceability by rmaddikery · Pull Request #276 · eclipse-score/logging

rmaddikery · 2026-08-25T15:12:23Z

Notes for Reviewer

Stats updated based on the links: https://eclipse-score.github.io/logging/pr-276/verification_report/stats.html

NOTE: We still need to cleanup the existing entries (legacy since those were from an internal codebase), but that will be part of the future release after we migrate entirely to score.

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-08-25T15:13:37Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 1c2ac2d4-8d66-4274-b5be-114791f392a3
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 17.936s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-08-25T15:38:46Z

The created documentation from the pull request is available at: docu-html

pawelrutkaq · 2026-08-26T05:40:39Z

I pinged @PiotrKorkus as he is testing lead, he will have a look

PiotrKorkus · 2026-08-26T05:50:24Z

   :derived_from: feat_req__logging__compat_dlt, feat_req__logging__log_sinks_network
   :status: valid
   :satisfied_by: comp__datarouter
+   :testlink: https://github.com/eclipse-score/logging/blob/main/score/datarouter/test/ut/ut_logging/test_dltserver.cpp#L150


testlinks have to be autogenerated from .xml test reports based on properties filled in test
https://eclipse-score.github.io/process_description//main/process_areas/verification/guidance/verification_templates.html

Hi @PiotrKorkus Since we have not entirely migrated to score and still relying on the exports from internal base, we cannot make changes to the sources here. In that regard, the test links here are references for later adaptations. I can create a follow-up task to track that. Works for you?

this testlink is not valid as it doesnt bring all the information about pass/fail from the test. I dont see any benefit of having such a placeholder.

Thanks for the feedback

@PiotrKorkus i see the build docs actually generates the stats from the test artifacts. I will wire it to what has already been linked to so that we do not lose that trace.

PiotrKorkus · 2026-08-26T16:56:24Z

+    RecordProperty("FullyVerifies", "comp_req__data_router__dlt_multiple_channels");
+    RecordProperty("Description", "Check that a DLT log channel can be constructed with default parameters.");
+    RecordProperty("TestType", "requirements-based");
+    RecordProperty("DerivationTechnique", "requirements-analysis");


Component requirements should be verified by Component Integration Tests not Unit Tests

true a unit does not cover it entirely, thanks

PiotrKorkus · 2026-08-26T17:00:49Z

 TOTAL_NONVERBOSE_MESSAGES = 11


-def test_datarouter_filters(target, datarouter_on_target, dlt_capture):


In Python we should use decorator according to the process https://eclipse-score.github.io/process_description//main/process_areas/verification/guidance/verification_templates.html#python-properties-template

There is ITF plugin for that: https://github.com/eclipse-score/itf/blob/1ce9b563e4a6f6b648ca313967fb2beb10f00317/score/itf/plugins/BUILD#L125-L132

- Helps identifying gaps in the module - Extend to inlcude all deps after other repos have fixed covrage as well

- for traceability of requirements

rmaddikery requested review from antonkri, arsibo and pawelrutkaq as code owners August 25, 2026 15:12

rmaddikery deployed to workflow-approval August 25, 2026 15:12 — with GitHub Actions Active

rmaddikery force-pushed the rama_adds_test_link branch from fb186c0 to b0bfd32 Compare August 25, 2026 15:26

rmaddikery requested a deployment to workflow-approval August 25, 2026 15:26 — with GitHub Actions Waiting

rmaddikery force-pushed the rama_adds_test_link branch from b0bfd32 to a3780a2 Compare August 25, 2026 15:28

rmaddikery deployed to workflow-approval August 25, 2026 15:28 — with GitHub Actions Active

github-project-automation Bot added this to LOG - Logging FT Aug 25, 2026

github-project-automation Bot moved this to Backlog in LOG - Logging FT Aug 25, 2026

rmaddikery force-pushed the rama_adds_test_link branch from a3780a2 to 86c4f51 Compare August 25, 2026 16:36

rmaddikery deployed to workflow-approval August 25, 2026 16:36 — with GitHub Actions Active

PiotrKorkus requested changes Aug 26, 2026

View reviewed changes

rmaddikery force-pushed the rama_adds_test_link branch from 86c4f51 to 8b2686d Compare August 26, 2026 06:39

rmaddikery requested a deployment to workflow-approval August 26, 2026 06:39 — with GitHub Actions Waiting

rmaddikery closed this Aug 26, 2026

github-project-automation Bot moved this from Backlog to Done in LOG - Logging FT Aug 26, 2026

rmaddikery reopened this Aug 26, 2026

rmaddikery requested a deployment to workflow-approval August 26, 2026 13:21 — with GitHub Actions Waiting

rmaddikery force-pushed the rama_adds_test_link branch from 8b2686d to 1fb471f Compare August 26, 2026 14:37

rmaddikery requested a review from 4og as a code owner August 26, 2026 14:37

rmaddikery requested a deployment to workflow-approval August 26, 2026 14:37 — with GitHub Actions Waiting

rmaddikery force-pushed the rama_adds_test_link branch from 1fb471f to 638fffa Compare August 26, 2026 14:38

rmaddikery deployed to workflow-approval August 26, 2026 14:38 — with GitHub Actions Active

rmaddikery changed the title ~~Adds test link to requirements~~ Adds record_property in unit tests for req traceability Aug 26, 2026

rmaddikery force-pushed the rama_adds_test_link branch from 638fffa to 8b43521 Compare August 26, 2026 14:55

rmaddikery requested a deployment to workflow-approval August 26, 2026 14:55 — with GitHub Actions Waiting

rmaddikery changed the title ~~Adds record_property in unit tests for req traceability~~ Adds record_property in tests for req traceability Aug 26, 2026

rmaddikery requested a deployment to workflow-approval August 26, 2026 15:09 — with GitHub Actions Queued

PiotrKorkus reviewed Aug 26, 2026

View reviewed changes

rmaddikery force-pushed the rama_adds_test_link branch from 9ce3033 to eef4334 Compare August 27, 2026 07:36

rmaddikery deployed to workflow-approval August 27, 2026 07:36 — with GitHub Actions Active

rmaddikery force-pushed the rama_adds_test_link branch from eef4334 to 73405ee Compare August 27, 2026 08:31

rmaddikery deployed to workflow-approval August 27, 2026 08:31 — with GitHub Actions Active

rmaddikery added 3 commits August 28, 2026 10:35

Scope requirements stats to module

e98ec9c

- Helps identifying gaps in the module - Extend to inlcude all deps after other repos have fixed covrage as well

Adds record_property in unit tests for req traceability

1f308ae

add_test_properties with req ids for component tests

f5c57fa

- for traceability of requirements

rmaddikery force-pushed the rama_adds_test_link branch from 73405ee to f5c57fa Compare August 28, 2026 10:35

rmaddikery requested a deployment to workflow-approval August 28, 2026 10:35 — with GitHub Actions Waiting

Navigation Menu

Uh oh!

Adds record_property in tests for req traceability - #276

Adds record_property in tests for req traceability#276
rmaddikery wants to merge 3 commits into
mainfrom
rama_adds_test_link

rmaddikery commented Aug 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

pawelrutkaq commented Aug 26, 2026

Uh oh!

PiotrKorkus Aug 26, 2026

Uh oh!

rmaddikery Aug 26, 2026 •

edited

Loading

Uh oh!

PiotrKorkus Aug 26, 2026

Uh oh!

rmaddikery Aug 26, 2026 •

edited

Loading

Uh oh!

rmaddikery Aug 26, 2026 •

edited

Loading

Uh oh!

PiotrKorkus Aug 26, 2026

Uh oh!

rmaddikery Aug 27, 2026 •

edited

Loading

Uh oh!

PiotrKorkus Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		TOTAL_NONVERBOSE_MESSAGES = 11


		def test_datarouter_filters(target, datarouter_on_target, dlt_capture):

Uh oh!

Conversation

rmaddikery commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

pawelrutkaq commented Aug 26, 2026

Uh oh!

PiotrKorkus Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmaddikery Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rmaddikery commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading

rmaddikery Aug 26, 2026 •

edited

Loading

rmaddikery Aug 26, 2026 •

edited

Loading

rmaddikery Aug 26, 2026 •

edited

Loading

rmaddikery Aug 27, 2026 •

edited

Loading