Skip to content

fix: metrics.json could use more data - #722

Open
Mr-Neutr0n wants to merge 1 commit into
eclipse-score:mainfrom
Mr-Neutr0n:agent/issue-685-metricsjson-could-use-m
Open

fix: metrics.json could use more data#722
Mr-Neutr0n wants to merge 1 commit into
eclipse-score:mainfrom
Mr-Neutr0n:agent/issue-685-metricsjson-could-use-m

Conversation

@Mr-Neutr0n

Copy link
Copy Markdown

Fixes #685

Added a small, documented needs_overview (total/external/local/by_type) to the generic metrics.json, updated its JSON schema, added tests, and documented it — the issue's guidance (no arbitrary data, hard to remove fields) was treated as instruction, not followed literally into an arbitrary dump.

Could not run the suite locally: /config/init.py:2234. Fork CI needs a maintainer approval to run, so this branch has no test signal yet.


This change was prepared with AI assistance under human direction and review.

Signed-off-by: Mr-Neutr0n <64578610+Mr-Neutr0n@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: bdeaaf86-66b3-42c5-875c-26191f443d73
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 6.929s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@AlexanderLanin

Copy link
Copy Markdown
Member

Hi @Mr-Neutr0n thanks for the contribution! I didn't look deeply into it yet, but doesn't it overlap with metrics_by_type?

@Mr-Neutr0n

Copy link
Copy Markdown
Author

Thanks for checking. metrics_by_type remains the per-requirement link coverage map, while needs_overview adds total, local versus external, and per-type counts across all needs, including non-requirement types, so the two sections serve different purposes. The current ECA failure is a legal-agreement gate rather than a code or test failure, so it needs to be resolved through the Eclipse contributor process.

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

I think here, we have to figure out what more data means firstly before we can go to the implementation phase.

That is our bad @Mr-Neutr0n , we will clarify this and come back once we have an answer.

@MaximilianSoerenPollak MaximilianSoerenPollak added question Further information is requested needs-refinement labels Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-refinement question Further information is requested

Projects

Status: refinement needed

Development

Successfully merging this pull request may close these issues.

metrics.json could use more data

3 participants