feat: permit 'token' claim on credential request to be generated by sts if configured - #1087
Merged
Merged
Conversation
ndr-brt
force-pushed
the
1086-credential-request-token-claim
branch
from
September 15, 2026 14:20
93d9b47 to
19ebb63
Compare
ndr-brt
force-pushed
the
1086-credential-request-token-claim
branch
from
September 15, 2026 15:02
19ebb63 to
2d91fbf
Compare
paullatzelsperger
approved these changes
Sep 16, 2026
paullatzelsperger
left a comment
paullatzelsperger
left a comment
Member
There was a problem hiding this comment.
fine for a workaround, but lets @Deprecated all the relevant places, so we can 🪓 it later
wolf4ood
approved these changes
Sep 16, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| EXPIRATION_TIME, Instant.now().plus(5, ChronoUnit.MINUTES).toString()) | ||
| ) | ||
| .compose(siTokenClaims -> secureTokenService | ||
| .createToken(participantContextId, siTokenClaims, configuration.bearerAccessScope())); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a configuration setting for the
CredentialRequestManager:edc.iam.credential.request.bearer.access.scope.When it is set, during the credential request, a token is requested to the STS with the configured scope and included in the request token as
tokenclaim.Why it does that
Briefly state why the change was necessary.
Further notes
CredentialRequestManagerhas 2 configuration settings.Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #1086
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.