Replace CertificatePinner with custom trust store using TrustManagerFactory - #112
Open
cisco-annikiti wants to merge 2 commits into
Open
Replace CertificatePinner with custom trust store using TrustManagerFactory#112cisco-annikiti wants to merge 2 commits into
cisco-annikiti wants to merge 2 commits into
Conversation
AaronAtDuo
reviewed
Aug 6, 2026
jeffreyparker
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace OkHttp's CertificatePinner (SPKI SHA-256 hash matching) with a custom trust store implementation using TrustManagerFactory initialized with a bundled KeyStore of root CA certificates.
Motivation and Context
CertificatePinner performs SPKI hash matching after TrustManager validation - it doesn't restrict the trust anchor set itself. The custom trust store approach restricts trust anchors at the TLS layer, provides full PKIX chain validation (signatures, expiry, chain building), and aligns with the standardized CA pinning approach across all Duo client libraries
How Has This Been Tested?
Types of Changes