docs(samples): align crew list extraction contract - #17
Draft
grevgeny wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1/crew-list-registrationsto the generic data-extraction README, C# endpoint sample, and Postman collection.FromDateTimeandToDateTimewhen the ChkBox bridge requests a historical backfill.Problem / Why
The public crew-list extraction endpoint was implemented and used by the dedicated ChkBox bridge, but it was absent from the generic public examples. The bridge also sent only
FromDateTimefor a backfill, while the API rejects one-sided historical ranges and requires both bounds.Validation
dotnet restore Ditio.Samples.csproj— restored successfully; NuGet vulnerability-data cache access emittedNU1900in the sandbox.dotnet build Ditio.Samples.csproj --no-restore -nologo -clp:Summary -maxcpucount:1 /nr:false /p:UseSharedCompilation=false— passed, 0 errors (sameNU1900cache warning).jq -e . postman/Ditio-Integration.postman_collection.json— passed.git diff --check— passed.Risk
Low. The endpoint inventory additions are documentation/sample-only. The request change makes the existing backfill path conform to the server's already-enforced date-range contract.
Notes
ditioas/timestyr.ditioas/timestyr#4202tracks separate server behavior for advertised ownership filtering and ordinary-user visibility; this PR does not change that behavior.ditioas/timestyr#4329: source review is clean, but the server documentation PR is blocked on unresolved integration-client access, project-filtering, and paging behavior.