fix(cketh): provision sweep gas out of the sweeper balance bound

[gregorydemay]

Why

• The funding task decides whether to top the sweeper address up from a lower bound on its ETH balance, tracked from the minter's own events (feat(cketh): sweeper fee-funding task, with an end-to-end test #11086). Nothing debited that bound, which was true while nothing spent from the sweeper address — and the layers below connect the sweep queue to the pipeline that does.
• Without a debit the bound only ever grows: fundings top the sweeper up once, sweeps spend the gas, and every counter still reports a full sweeper — amount_due declines fundings the sweeper actually needs, and sweeping stalls while looking healthy.

What

• An accepted sweep provisions the most it can cost the sweeper address: its fee ceiling, the same ceiling every resubmission is checked against. A sweep moves its ERC-20 through call data and sends no ETH — settlement reads the finalized transaction and its receipt, asserts exactly that, hands back the fee the sweep did not pay, and records the fee it did.
• A sweep is only accepted while the bound covers its ceiling, so every hold is backed by delivered gas. That lets the balance be checked like the main address' EthBalance instead of floored at zero: provisioning beyond deliveries is a bug to surface, not a state to tolerate (no deployed minter ever wrote a sweep event, so there is no legacy log to indulge).
• Provisioning at acceptance rather than debiting at spend keeps the bound erring low while sweeps are in flight: a sweep whose finalization is never observed brings a funding forward rather than letting the minter believe in gas that is gone. Acceptance also happens exactly once per sweep, where a signature happens once per resubmission.
• The holds stay out of cumulative_spent — that ETH was counted there when the funding delivered it, and counting it twice would trip the burn-first invariant (R14).
• The sweep e2e now funds the sweeper the way production does — ckETH burned from the fee account, delivered and finalized by the funding pipeline — since a minter that trusts only its own accounting no longer sweeps on gas credited behind its back.

This is #11329 (thanks @mbjorkqvist), integrated on top of the sweep stack per the hand-off on DEFI-2933: rebased onto the sweep-queue lifecycle, whose deposit release now lives in the same finalization transition the refund settles in.

[Copilot]

Pull request overview

Updates ckETH sweeper funding accounting so in-flight and finalized sweep costs correctly reduce the tracked balance lower bound.

Changes:

• Provision accepted sweeps against the sweeper balance bound.
• Refund unused fees and failed transfer values upon finalization.
• Add lifecycle tests, shared fixtures, and updated documentation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
rs/ethereum/cketh/minter/src/test_fixtures.rs	Adds a reusable sweep request fixture.
rs/ethereum/cketh/minter/src/state/transactions/tests.rs	Reuses the shared sweep fixture.
rs/ethereum/cketh/minter/src/state/sweeper_funding/tests.rs	Tests provisioning, refunds, accounting invariants, and flooring.
rs/ethereum/cketh/minter/src/state/sweeper_funding.rs	Tracks provisioned and refunded sweep costs.
rs/ethereum/cketh/minter/src/state/audit.rs	Wires accounting into sweep lifecycle events.
rs/ethereum/cketh/minter/src/state.rs	Settles sweeper balance accounting at acceptance and finalization.
rs/ethereum/cketh/docs/deposit_from_cex.md	Documents the revised lower-bound calculation.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

rs/ethereum/cketh/minter/src/state/automatic_deposits/mod.rs:220

• This literal emits large runs of spaces in the operational log message, making failure diagnostics harder to read. Use Rust line continuations so source wrapping produces single spaces.

                    "[record_finalized_sweep_transaction]: DROPPING {request:?} from the sweep                      queue: {id:?} failed and the minter does not retry. Its {:?} stays at {}, and                      reaching it again needs the pair armed afresh.",

rs/ethereum/cketh/test_utils/src/anvil.rs:316

• Blocks are searched newest-first, but transactions within each block are still searched oldest-first. With interval mining, multiple transactions from this sender can share the head block, so this can return an earlier transaction rather than the documented most recent one. Reverse the per-block iteration too.

            for transaction in transactions {

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

[zeropath-ai]

✅ No security or compliance issues detected. Reviewed everything up to 1835071.

Security Overview

• 🔎 Scanned files: 11 changed file(s)
• 🔗 Scan Link: https://zeropath.com/app/repositories/783a9bd4-fb4e-4e10-ab3c-c2fb2ddfb92f?scanId=165193b9-b45c-43e1-8938-4c93d33fcf7d&codeScanTypes=PrScan&tab=issues

Detected Code Changes

Change Type	Relevant files
Enhancement	► rs/ethereum/cketh/minter/src/state.rs     Add record_finalized_sweeper_transaction method ► rs/ethereum/cketh/minter/src/state.rs     Add update_sweeper_balance_upon_accepted_sweep method ► rs/ethereum/cketh/minter/src/state/audit.rs     Call update_sweeper_balance_upon_accepted_sweep during sweep event processing ► rs/ethereum/cketh/minter/src/state/automatic_deposits/mod.rs     Expose processed_sweep_request method
Enhancement	► rs/ethereum/cketh/minter/src/state/sweeper_funding.rs     Introduce SweeperBalance and SweeperBalance handling (credit/debit, add_error checks) ► rs/ethereum/cketh/minter/src/state/sweeper_funding.rs     Extend SweeperFundingAccounting with sweeper_balance, new methods record_accepted_sweep, record_finalized_sweep, total_effective_sweep_fees, sweeper_balance_lower_bound
Enhancement	► rs/ethereum/cketh/minter/src/sweep/mod.rs     Prevent creating pending sweeps when sweeper balance cannot cover max_transaction_fee
Enhancement	► rs/ethereum/cketh/minter/src/sweep/tests.rs     Add tests for sweeper balance behavior: should_not_accept_a_sweep_the_sweeper_gas_cannot_pay_for, should_record_the_fees_sweeps_paid, and support for finalized sweeps with replacements
Enhancement	► rs/ethereum/cketh/minter/src/test_fixtures.rs     Add PREPAID_SWEEP_GAS constant, prepay_sweep_gas, and state_with_enqueued_sweep helpers; extend fixtures with sweep-related setup
Enhancement	► rs/ethereum/cketh/minter/tests/deposit_from_cex.rs     Adjust test setup to use new sweep funding flow and dynamic funded gas amount
Enhancement	► rs/ethereum/cketh/test_utils/src/live.rs     Update live test setup to reflect new sweep funding semantics and include TransactionStatus in events
Enhancement	► rs/ethereum/cketh/test_utils/src/live.rs     Refactor new_sweep to initialize via new approach and adjust funding flow for tests
Enhancement	► rs/ethereum/cketh/minter/src/sweep/tests.rs     Add tests for not accepting sweeps when gas cannot be covered, and related fixtures for state with enqueued sweeps

[mbjorkqvist]

LGTM, thanks @gregorydemay!