You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2026-08-21T00:06:18.836-0500 INFO {"level":"debug","ts":"2026-08-21T00:06:18.836-0500","msg":"stopping Devsy container"}
Root cause
deleteContainer/stopContainer in workspace_client.go run devsy internal agent workspace delete|stop as a subprocess and capture
its stdout/stderr with log.Writer(log.LevelInfo). cmd/internal/agent.go
always forces internal commands to --log-output json, so that subprocess
only ever emits structured JSON log lines. log.Writer's levelWriter just
re-logs each captured line verbatim as a message — wrapping the child's
already-JSON line inside another log record.
Fix
Use log.PipeJSONStream() instead, which parses each line and re-emits it
at its original level/message. This is the same pattern already used for
other internal JSON-emitting subprocesses (cmd/workspace/ssh.go, cmd/workspace/gpg_tunnel.go, pkg/client/clientimplementation/proxy_client.go).
Close+drain moved to a defer so early-return paths (e.g. agentWorkspaceCommand
failing) still drain the pipe goroutine before returning.
Verification
go build ./...
go vet ./pkg/client/clientimplementation/...
go test ./pkg/client/clientimplementation/...
Summary by CodeRabbit
Bug Fixes
Improved logging during workspace container deletion and stop operations.
Ensured operation logs are fully processed before cleanup completes.
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Walkthrough
Workspace container deletion and stopping now use log.PipeJSONStream(). Both operations close the stream and wait for its goroutine before cleanup completes.
Container deletion and stopping replace the direct info-level writer with a JSON log stream. Each operation waits for stream completion after closing the stream.
The change prevents workspace stop/delete subprocess logs from being double-encoded while preserving their original log level and message; no actionable merge-blocking risk remains after normal checks and review.
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The title clearly describes the main change: streaming internal subprocess logs through PipeJSONStream to fix client log handling.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches✨ Simplify code
Create PR with simplified code
Commit simplified code in branch fix/workspace-client-json-log-nesting
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).
If you're new to commit signing, there are different ways to set it up:
Sign commits with gpg
Follow the steps below to set up commit signing with gpg:
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
deleteContainer/stopContainer capture stdout/stderr from
`devsy internal agent workspace delete|stop`, which cmd/internal/agent.go
always forces to --log-output json. Piping that through log.Writer
re-logged each raw JSON line verbatim as a message, producing doubly
nested JSON log records. Switch to log.PipeJSONStream, which unwraps
each line and re-emits it at its original level, matching the existing
pattern used for other internal JSON-emitting subprocesses (ssh.go,
gpg_tunnel.go, proxy_client.go).
Signed-off-by: Samuel K <skevetter@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workspace stop/delete logs showed doubly nested JSON:
Root cause
deleteContainer/stopContainerinworkspace_client.gorundevsy internal agent workspace delete|stopas a subprocess and captureits stdout/stderr with
log.Writer(log.LevelInfo).cmd/internal/agent.goalways forces internal commands to
--log-output json, so that subprocessonly ever emits structured JSON log lines.
log.Writer'slevelWriterjustre-logs each captured line verbatim as a message — wrapping the child's
already-JSON line inside another log record.
Fix
Use
log.PipeJSONStream()instead, which parses each line and re-emits itat its original level/message. This is the same pattern already used for
other internal JSON-emitting subprocesses (
cmd/workspace/ssh.go,cmd/workspace/gpg_tunnel.go,pkg/client/clientimplementation/proxy_client.go).Close+drain moved to a
deferso early-return paths (e.g.agentWorkspaceCommandfailing) still drain the pipe goroutine before returning.
Verification
go build ./...go vet ./pkg/client/clientimplementation/...go test ./pkg/client/clientimplementation/...Summary by CodeRabbit