fix(ci): create GitHub Releases for scheduled auto-version tags - #62
Merged
Conversation
Scheduled and workflow_dispatch builds tag with GITHUB_TOKEN, which GitHub will not use to start release.yml. Call release.yml via workflow_call after a successful image push, run version-manifest against the computed tag, and stop rendering the floating tag as vv1. Human/PAT tag pushes still use release.yml on:push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weekly/
workflow_dispatchbuilds inbuild.ymlcreate a git tag withGITHUB_TOKENand push it. GitHub does not start other workflows fromGITHUB_TOKENevents, sorelease.yml(on: pushtags) never ran. Result: tagsv1.12.11–v1.12.16exist, onlyv1.12.10(humanmake release) has a GitHub Release,v1is stuck on00a4e64, andversion-manifestskipped becausegithub.refwasrefs/heads/main.Change
release.ymlworkflow_callwith a requiredtaginput (still handles human/PAT tag pushes viaon: push).build.ymlcallsrelease.ymlforschedule/workflow_dispatch.version-manifestusesbuild-and-push.outputs.tagand runs whenever the image push succeeded (release created or already present).vv1→v1.Test Plan
build.yml; workflow-only change)workflow_dispatch) creates a GitHub Release and attachestool-versions.jsonmake release/ PAT tag push still hitsrelease.ymlviaon: push(create-release job skipped)I will backfill a GitHub Release for v1.12.16 (the image we just published) and move the
v1floating tag to match. Older weekly tags (v1.12.1–v1.12.15) can be backfilled the same way if you want them.